Provide a better message for erroneous values folder files #4490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task generateComposeResClass created an error message that didn't help the user to understand the problem if files other than strings.xml were in the values folder. This fix improves on the message so that users can quickly fix the underlying issue.
The old message was "Unknown resource type: 'values'." But not values is the problem, but a file like - in my case - colors.xml which I copied from an existing Android project (well, yeah, I shouldn't have done that, but anyway, the message was not helpful).
The new message would be "Forbidden file name 'colors.xml'! Only a file for string resources named 'strings.xml' is valid in the 'values' folder." I also added a check for this in the ResourcesTest's
testGeneratedAccessors()
method.