Fix TapGestureDetector mutex is not locked error on Touchscreen #824
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JetBrains/compose-multiplatform#3655
The issue is introduced after migration to
awaitPointerEventScope
, this code is indeed has a race condition, as it was assumed in the TODO. When we send Press/Release without any moves - we go via this path:To avoid races, we should always access
pressScope
inlaunch
(this way the calls maintain order).The same approach is used in the original
TapGestureDetector.kt
(the change in commit 32de9dd)Also, the rest of the code doesn't have races with
pressScope
calls.Testing