JBR-6847 Improve locking performance on Windows #343

…s full screen This includes displaySync changes as well as fixes for JBR-5157 and JBR-5321.

Removed extra command queue

Use separate glyph cache for each MTLContext instance. Refactored MTLGlyphCache

…nnouncer_nativeAnnounce Stop using the JNIEnv instance bound to EDT in the AppKit thread. (cherry picked from commit 0f49341)

… queue Added command queue and provided synchronization between the command queues

…uffer and a specific shader (vert_txt_col) fix crash in J2DDemo with advanced paints + artefacts with texture background

…ronization in metal (MBP 16'' x64) Removed NSLock and moved all operations to the AppKit thread

…hronization in metal (MBP 16'' x64) Replaced NSMutableArray with NSMutableSet, removed unnecessary __block modifier.

… be not higher 2.17

Provided corrected initial value for currentDisplayID

…use 1 larger quad instead of many quads per row, full-tile is only using 1x1 pixel (full), applied to color, gradient & texture paints + fixed clang warnings

(cherry picked from commit 0d663a1)

- add Swing/AWT specific Task runners - split MouseEventsOnClientArea to separate AWT/Swing tests - use CountDownLatch for tracking mouse events

- set windows always on top - verify mouse location before clicking

…ctionListenerTest

* don't move into itself * use `PKG_NAME` variable instead of `${APP_NAME}.pkg` * cleanup sign.sh * add `SCRIPT_VERBOSE` env variable to control `set -x`

…h -Xcheck:jni. - Create a global reference of the passed to EDT accessible object (the local reference) to use it in the AppKit thread ; - Enable -Xcheck:jni in the tests ; - Make the tests handle the problematic case . (cherry picked from commit cba981d)

…full app sign

…t out of the window

restore original display mode

…yTest.java: JDialog transparency lost upon iconify/deiconify sequence Corrected startRedraw method to call setNeedsDisplay in displaySync=false mode

Corrected printf format and muted unused-function option for keycode_cache.c

- verify that the popup menu is usable if overlaps WM's dock panel of the bottom of screen

…undled ones

Removed display sync from window layer, provide layer content updates only when necessary

…active application

…ons' release/clicked events

add mouse events logging

…tain the pressed button's modifier. Enforce keeping the pressed button in the modifiers for MOUSE_DRAGGED events. This is under a (default enabled) system property "awt.mac.enforceMouseModifiersForMouseDragged". (cherry picked from commit fb12990)

…fault (see new system property 'sun.java2d.metal.colorMatching=true/false') + added new MetalLayerColorTest Use CGColorSpaceCopyName() available since macOS 10.6 in MTLLayer Use sun.java2d.metal.colorMatching=true by default (current metal behaviour)

… Failed: OpenGL 26 image rendering failure(s) Added synchronisation for rendering and appearance

…heckbox is not selected Fixed the test to use proper cell coordinates when clicking.

…tor with different scale

Do not search for the containing monitor in MouseInfo.getPointerInfo, this must be handled by peers (yes, this goes against the spec of MouseInfoPeer.fillPointWithCoords). JBR-5268 Fix coordinates conversion in XMouseInfoPeer.fillPointWithCoords

…t and VoiceOver is enabled done as part of JBR-4993 Support using 'main' thread as EDT on macOS (cherry picked from commit 5559869)

…ponents using TextLayout.draw

…nent inserts the composed text there

(cherry picked from commit 4c6f3e4)

Added extra redraw request

- Implements the optional method [NSTextInputClient windowLevel] to tell the macOS IM subsystem correct level of the window; - Adds a regression test ImWindowIsPlacedUnderPopup5984.java. (cherry picked from commit 5a91aae)

Blit operation should not be performed on textures with MTLTextureUsageRenderTarget only, so changing framebufferOnly to NO

Restored REDRAW_INC to 2. Enabled the fix by default only for M2 and spans displays property enabled (Displays have separate spaces OFF)

…bold Replaced Inter bold with semi-bold fonts

…slating F13-F24 keys

…see BBoxAATileGenerator), added new statistics in Renderer

…rom stdout/stderr

Added missing parameter

…SIGSEGV at Symbol::as_klass_external_name(char*, int) Do not use print_native_stack() when recording OOME stacks as it is designed to be used only in the context of a fatal error reporting where induced crashes are tolerated.

…itialization

…dVMOptions has become the default (cherry picked from commit ae5963a)

….java2d.opengl.CGLGraphicsConfig cannot be cast to class sun.java2d.metal.MTLGraphicsConfig Prevent fall back to OpenGL if Metal has been used before Added more diagnostics.

…after recreation of graphics device. Reverted fix of the JRE-359 (CGraphicsEnvironment.getDefaultScreenDevice() returns null) Logged exception after first attempt to create graphics device

Moved metal load library checks to CGraphicsEnvironment

- AWT code heavily relies on reference comparison when updating graphics devices & configurations, so we need to actually re-create CGraphicsDevice if it was changed. - Also do not rely on graphicsConfig.getDefaultTransform() when firing `graphicsContextScaleTransform` property change, as graphics devices are mutable and returned default transform may change over time, e.g. when device is invalidated.

Marks the native flag AwtClipboard::isGettingOwnership as volatile and adds memory barriers around it to avoid inconsistencies of CPU caches.

(also contains the fix of JBR-6267 Image retreived from the Clipboard is not the same image that was set to the Clipboard) - Adds a way to disable caching of the data placed into the clipboard. The behavior is controlled by the system property "awt.windows.clipboard.cache.disabled" (=false by default) ; - Whenever the app gets focus additionally checks if another app has modified the clipboard. The behavior is controlled by the system property "awt.windows.clipboard.extraOwnershipChecksEnabled" (=true by default) .

…d off Drop the maximized state right before the resize operation for undecorated windows. Also fixes setExtendedState() to work when changing snapped window's state (MAXIMIZED_HORIZ or MAXIMIZED_VERT) to NORMAL.

…itx and ubuntu 13.04. - introduces and integrates jbNewXimClient: a new implementation of XIC creation routine (it's mostly refactoring and generalizing of AWT's existed code). Enabled by default and can be disabled via a new system property -Djb.awt.newXimClient.enabled=false ; - introduces support of the X11's native over-the-spot input method style (it's almost the same as AWT's below-the-spot mode, but the input method's windows are drawn externally, not by AWT). Enabled by default and can be disabled via a new system property -Djb.awt.newXimClient.enabled=false. Doesn't work if -Djb.awt.newXimClient.enabled=false is set ; - introduces sun.awt.X11.XInputMethod.ClientComponentCaretPositionTracker class that tracks all kind of events for the current client component that can lead to the caret position changing ; - makes the XInputMethod class to update the input window's position (whenever the ClientComponentCaretPositionTracker discovers that's necessary) by setting the X11's XNSpotLocation property . Check out the branch nprovotorov/backups/JBR-2460_wrong-position-of-input-window-and-no-input-preview for more granular patches. (cherry picked from commit c57030a)

…itx and ubuntu 13.04. This patch makes the fix of JBR-1573 (which caused JBR-4394) disabled by default, because it's incompatible with the native below-the-spot mode (a.k.a. over-the-spot in the X11's terminology). (cherry picked from commit 3fe2a97)

Removed sync code

… Attempting to acquire lock OOMEStacks_lock/safepoint out of order

…rmittently fails due to deadlock. Makes the test invoke any UI-operation on EDT only (since AWT doesn't guarantee thread-safety of UI operations, see more at https://mail.openjdk.org/pipermail/client-libs-dev/2023-November/016172.html). (cherry picked from commit 8dbb889)

JBR API v0.0.8 Added new WindowDecorations API, deprecated old CustomWindowDecoration. JBR-4641 JBR-4630 Fix client area calculation with custom decorations on Windows. - Window insets are rounded up, which causes visible & unusable border in fullscreen on some scales, round down instead. - Clipping in Swing components sometimes cuts what it shouldn't, fixed.

fix copyright profile in generated IDE project (cherry picked from commit 43ebbe3)

JBR-5023 Configure TabbingIdentifier during create native window JBR-5256 IDEA window resizes to zero height when exit full-screen mode with new window controls enabled JBR-5197 Window control buttons are not visible in full-screen mode in dark themes when IDE window is focused JBR-5175 jb/java/awt/Window/FullScreenTwoFrames.java: -[AWTWindow resetWindowFullScreeControls]: unrecognized selector sent to instance 0x60000232d5f0 JBR-5499 Window control buttons bugfix JBR-4462 BigSur: project tab does not gain focus when click it after focusing another app

…/right corner

…n an external monitor

…ized windows to un-minimize

The data can be provided via this JBR API call: JBR.getJstack().includeInfoFrom(Supplier<String>)

Introduced JBR.isWindowMoveSupported() and JBR.getWindowMove().startMovingTogetherWithMouse()

…csEnvironment Co-authored-by: Nikita Gubarkov <nikita.gubarkov@jetbrains.com>

Updated the XToolkit implementation to match API changes required for WLToolkit

…l projects were initially opened on secondary monitor Announce to Mutter that we are "client-decorated" when a Frame is undecorated by setting _GTK_FRAME_EXTENTS to all zeroes. This prevents Mutter from applying certain harmful heuristics.

…ecame failing by time out on Linux

1. Remove `value == nil` check in ComboBoxAccessiblity.accessibilityValue to fix the issue with not updated value of combo box. With `value == nil` check, the value was not reassigned on every get request of `accessibilityValue`, but only on get `accessibilitySelectedChildren`. When changing focus by Tab, only get `accessibilityValue` is called, and because `value` is already not nil, an old value was returned. 2. Set combo box role to NSAccessibilityPopUpButtonRole if it's not editable. Setting role to popup button fixes the bug when combo box value was not updated when using VO cursor navigation. Native MacOS non-editable combo boxes and non-editable HTML <select> elements also have the "popup button" role instead of "combo box", so the role should become more clear. Popup button role additionally enables opening the combo box menu with VO+Space shortcut, and changes VO instructions to be more appropriate when combo box is focused. 3. Add test for VoiceOver-specific issues of JComboBox. (cherry picked from commit 8982db5)

(cherry picked from commit 0dfbf34)

…ont" This reverts commit c5cc5b4.

…cript in jbr17

…stuck while traversing.

… in separate file

…op/unix/native/common/awt/fontpath.c Reviewed-by: prr

…native methods in fontconfigmanager

…om border color

- Removed font fallback hacks. - Changed composite font glyph code encoding scheme, refactored to use Font2D instead of PhysicalFont. - New Emoji logical font type with 2 underlying physical fonts. - Removed getGlyphVectorOutline - it's unused and broken. - Got rid of charsToGlyphs[NS] boilerplate. - Moved emoji tests to separate directory.

(cherry picked from commit a4acdf0) (cherry picked from commit 9178b24)

(cherry picked from commit 9626cc1) (cherry picked from commit 09d1ab6)

(cherry picked from commit def4d8a)

…ocused. Fixes a data race in the test. (cherry picked from commit ca55622) (cherry picked from commit 1ba73c8)

…screen mode - moved common logic to a separate part - moved parts of tests to swing package (cherry picked from commit 80b6e4b)

(cherry picked from commit 6995ce4) with fix for JBR-5189 Can't exit fullscreen mode on ubuntu 22.10 (cherry picked from commit b933660) (cherry picked from commit f4ea24e)

(cherry picked from commit 9b813e2)

…ation. (cherry picked from commit 26684fd)

(cherry picked from commit 0aee99a)

(cherry picked from commit d2301ed)

…tween monitors (cherry picked from commit 83c4c03)

Uses CFS_EXCLUDE instead of CFS_CANDIDATEPOS in the ::ImmSetCandidateWindow() native API, which is more powerful and allows to take into account the issue's case. (cherry picked from commit 0afe6c3)

Created intermediate buffer in the MTLLayer Implemented frame separation of window updates for AWT and Swing Remove frame delays as they greatly affect throughput Fixed test/jdk/sun/java2d/GdiRendering/ClipShapeRendering.java Resolved crash on multi-GPU systems

Removed opacity from CAMetalLayer for layers with rounded corners

…wProps test. Calling setDisplayMode() or setFullScreenWindow() may cause display reconfiguration.

… via shortcut with auto-maximize enabled in Mutter Windows no longer change their "native" size when moved between monitors with different scale on Linux. Use -Dresize.with.scale=true to revert that.

…multiple windows

This reverts commit 9aa690a.

…restore JavaDraw performance (more frames rendered than real vsync FPS)

…zation

JBRE-MR-368 (cherry picked from commits f0d5a90, 5befaea, ea2c4bf, 04601189604827c115a5a3b36aa268ba5c39ef3dб 20468cf)

Introduction of JBR API changed the order of modules appearing in Java Doc. This commit updates the corresponding tests to match the current output with JBR API.

…nd --with-vendor-bug-url

… test

…read_mutex_t)

…fig (pthread_mutex_t)" This reverts commit e7e3638.

This reverts commit 7712e52.

- Re-create all GraphicsDevices on displayChanged()

…MTLGraphicsConfig Performing flush of pending rendering operation before destroying MTLGraphicsConfig

Also correct library name encoding in exception messages. with fix for JBR-5300 Change source code and test files to use GPL license

…mouseDown by default

…ile in tmp dir only (cherry picked from commit 4bd3f78)

…va.util.PropertyPermission" "sun.tools.attach.tmp.only" "read") (cherry picked from commit 3a09f6c)

Initial implementation for linux and macOS

run_rp.sh - additional checks

…oid NPE (cherry picked from commit 9393760)

…isibleTestLinuxGnome.java: title bar shown and hidden are the same. Exclude the test when running under XWayland that doesn't implement screen capture necessary for the test to function.

…closing application

* Call UAZoomChangeFocus function when the keyboard focus is changed or when an accessible selection event is fired. Zoom viewport fill follow the accessible frame of the newly focused component, and if it has a selected child, its frame will be passed as part that needs to be highlighted. * Fix an exception in ComboBoxAccessibility.accessibilitySelectedChildren when its selection is nil. This happens when a combo box doesn't have a selected item, and it this case Zoom wouldn't be able to follow the combo box location. * Move the native handler of CAccessibility.focusChanged method from the legacy JavaComponentAccessibility to the new CommonComponentAccessibility class. It calls a class method (like a static method in Java), so there is no difference in which specific class it's located, but it allows to write the new code in the appropriate class. (cherry picked from commit 75b0642)

…ing Chinese input method. Fixes different platform-specific issues with disabling/enabling input methods support via java.awt.Component#enableInputMethods(boolean): * Windows: disabling used to require to deactivate and then activate back the app window to be performed completely ; * macOS: disabling used to leave the input method window visible (however, it wasn't affecting the input) ; * Linux: with fcitx5 IMF (may not be reproduced with iBus) disabling and then enabling back the input method support used to reset the used input source (keyboard layout) to a default one. It's done via disabling the current XIM when the input method support is disabled instead of disposing it . (cherry picked from commit 2933ea8) The patch also contains the fix for "JBR-6711: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java: JButton JPanel not collected." It unsets its references to tracked components thus not preventing GC from collecting them. (cherry picked from commit e9aab98)

* Execute AccessibleAnnouncer.nativeAnnounce on a background thread on Windows to fix UI freezes. IntelliJ calls this method from EDT, but it doesn't need to run on EDT because on Windows it simply calls screen readers API without interacting with UI components. Additionally, when using a background thread, the JAWS SayString method, which previously could have been running for multiple seconds, is now executed immediately as expected, but the root cause of previous delays is unclear. * In JawsAnnouncer, initialize COM library with the multithreaded model to allow executing it from different threads. Now COM is initialized and uninitialized on every call of the method as required by the [documentation](https://learn.microsoft.com/en-us/windows/win32/learnwin32/initializing-the-com-library): "Each thread that uses a COM interface must make a separate call to this function. For every successful call to CoInitializeEx, you must call CoUninitialize before the thread exits". IJawsApi COM object is still static and reused by different threads, which is allowed with a multithreaded concurrency model. It shouldn't cause issues because it has no state and only forwards calls to JAWS. (cherry picked from commit 8cc4cd5) (cherry picked from commit d7d8d9b)

…MTLGraphicsConfig Fix of MT access to shared data in MTLGraphicsConfigInfo

Added explicit platform target

…ache. (#334)

…keycode on different keyboard layouts"

Remove unused import that broke compilation

…getKeyboardLayoutNativeId. A theoretical fix, it should: - Catch any NSException (as it was initially expected); - Probably fix possible memory leaks (by moving the layoutId var inside autoreleasepool).

This reverts commit 21bffd0.

with fix for JBR-5300 Change source code and test files to use GPL license

…tests

…with "U.S. International - PC" layout" This reverts commit 5049cad. After JBR-5173 this workaround is no longer necessary

with fix for JBR-5300 Change source code and test files to use GPL license

…nding VK_ constant on macOS

…t exist in KeyCodesTest

…us switch [macOS]

…or font

Ignores the IM text returned from XmbLookupString/XwcLookupString if the KeyPress event which XmbResetIC was called with was synthetic and the first after a call of XmbResetIC/XwcResetIC. (cherry picked from commit 43a9a3a)

Use -XX:+UnlockExperimentalVMOptions -XX:-UseCriticalSection to revert to the old behavior

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JBR-6847 Improve locking performance on Windows #343

JBR-6847 Improve locking performance on Windows #343

Commits on Mar 20, 2024