Refactor ::derive_more absolute paths to just derive_more (#338)
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #338
Synopsis
At the moment, the
derive_moremacros cannot be re-exported or thederive_morecrate cannot be renamed as the dependency, because expansions require::derive_moremodule be present in the scope. See #338 for details.Solution
Use
derive_more::*paths instead of::derive_more::*in expansions, allowing to provide this module in the scope on the call site even whenderive_moreis transitive dependency of the crate.Checklist
Tests are added/updated(not required)CHANGELOG entry is added(not required)