Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LoadingButton removed from nova core #93

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

alancolant
Copy link
Contributor

@alancolant alancolant commented Nov 7, 2023

This PR reintroduces the LoadingButton component, which was removed from the core of Laravel Nova since version 4.28.
Its absence prevented the submission of the creation modal.

This issue has been resolved by reintegrating the old component under a new name.

Fix issue #92

@ralphschindler
Copy link

This looks like a solid fix, thanks!

@JeffBeltran
Copy link
Owner

Thanks @alancolant looks good to me, i thought i saw on twitter they are going to release a UI kit, is that still the case? or was that a fever dream?

@JeffBeltran
Copy link
Owner

@alancolant if you can fix the commit message i'll get this merged asap, otherwise i will need to wait til after in the day when i get time. I really should add a contribution guide but... well time

@juanr-yes
Copy link

hope this gets solved soon! thanks for the effort guys

@alancolant alancolant changed the title fix LoadindButton removed from nova core fix: LoadindButton removed from nova core Nov 12, 2023
@alancolant alancolant changed the title fix: LoadindButton removed from nova core fix: LoadingButton removed from nova core Nov 12, 2023
@alancolant
Copy link
Contributor Author

@JeffBeltran commit message updated

LucasLavallee pushed a commit to LucasLavallee/sanctum-tokens that referenced this pull request Nov 14, 2023
@galengidman
Copy link

This is currently a blocker for us - would love to see this merged soon. Thanks all!

@JeffBeltran JeffBeltran merged commit 92b1577 into JeffBeltran:master Nov 20, 2023
Copy link

🎉 This PR is included in version 2.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JeffBeltran JeffBeltran linked an issue Nov 20, 2023 that may be closed by this pull request
@galengidman
Copy link

Thanks much @JeffBeltran and @alancolant

@JeffBeltran
Copy link
Owner

no problem, sorry it took me a bit to get it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<LoadingButton> was removed in Nova 4
5 participants