-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LoadingButton removed from nova core #93
Conversation
This looks like a solid fix, thanks! |
Thanks @alancolant looks good to me, i thought i saw on twitter they are going to release a UI kit, is that still the case? or was that a fever dream? |
@alancolant if you can fix the commit message i'll get this merged asap, otherwise i will need to wait til after in the day when i get time. I really should add a contribution guide but... well time |
hope this gets solved soon! thanks for the effort guys |
@JeffBeltran commit message updated |
This is currently a blocker for us - would love to see this merged soon. Thanks all! |
🎉 This PR is included in version 2.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks much @JeffBeltran and @alancolant |
no problem, sorry it took me a bit to get it merged |
This PR reintroduces the LoadingButton component, which was removed from the core of Laravel Nova since version 4.28.
Its absence prevented the submission of the creation modal.
This issue has been resolved by reintegrating the old component under a new name.
Fix issue #92