Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new expired date column #84

Closed
wants to merge 1 commit into from
Closed

add new expired date column #84

wants to merge 1 commit into from

Conversation

LucasLavallee
Copy link

No description provided.

@JeffBeltran
Copy link
Owner

Thanks @LucasLavallee i'll take a look at this but unless this is a feature supported by sanctum i'll prob not pull this in

@JeffBeltran JeffBeltran added the enhancement New feature or request label May 13, 2023
@AndreSchwarzer
Copy link

Hey @JeffBeltran did you have a chance to look into this?

expires_at is native to Sanctum. Here is the merged PR and the Upgrade Guide.

@JeffBeltran
Copy link
Owner

oh man sorry @AndreSchwarzer i just realized i dropped the ball on this PR, let me look it over again and i'll get this implemented

@AndreSchwarzer
Copy link

AndreSchwarzer commented Jan 10, 2024 •
edited

Hi @JeffBeltran

did you already find some time to look into it?

Thanks <3

JeffBeltran added a commit that referenced this pull request Mar 7, 2024
@JeffBeltran
feat: show token expiration
8227e15 
- Added missing token expiration to token table

partly related to #84
@JeffBeltran JeffBeltran mentioned this pull request Mar 7, 2024
Merged
JeffBeltran added a commit that referenced this pull request Mar 7, 2024
@JeffBeltran
feat: show token expiration (#100)
374d450 
- Added missing token expiration to token table

partly related to #84
github-actions bot pushed a commit that referenced this pull request Mar 7, 2024
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
649ff17 
# [2.1.0](v2.0.5...v2.1.0) (2024-03-07)

### Features

* show token expiration ([#100](#100)) ([374d450](374d450)), closes [#84](#84)
@JeffBeltran
Copy link
Owner

I have added the column to the table view via #100 but i need to do some UI work before i can add the ability to set the expiration date. I'm going to close this for now since I have a plan to get this feature supported

@JeffBeltran JeffBeltran closed this Mar 7, 2024
@webard webard mentioned this pull request Mar 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucasLavallee @JeffBeltran @AndreSchwarzer