Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox selection type for abilities #78

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

LucasLavallee
Copy link

No description provided.

@JeffBeltran
Copy link
Owner

Thanks for the PR @LucasLavallee, if you update the readme with the changes i'll be happy to get this merged

@JeffBeltran JeffBeltran added the needs more info There was not enough information provided to troubleshoot this further label Mar 9, 2023
@LucasLavallee
Copy link
Author

Hi ! I just updated the Readme :). I also make a fix to make sure that available abilities are always visible even after canceling or closing the creation modal.

@JeffBeltran
Copy link
Owner

JeffBeltran commented Mar 15, 2023

Thanks @LucasLavallee i'll take a look at this over the next few days and get it merged. Thanks for your contribution

@JeffBeltran
Copy link
Owner

hey @LucasLavallee just wanted to let you know that im still looking at this, i think i want to make a few slight changes but overall i think this is a nice feature. I like the idea of selecting from pre-made abilities and i wanted to give options to be text based (current), checkboxes (like this) and also a multiselect. but i'll want to think on this API before i merge this

@JeffBeltran JeffBeltran added documentation Improvements or additions to documentation enhancement New feature or request and removed needs more info There was not enough information provided to troubleshoot this further labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants