Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DummyInput.tsx, Input CSS hack replaced with improved and efficient code. https://github.com/JedWatson/react-select/issues/5722 #5727

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MiladKarandish
Copy link

@MiladKarandish MiladKarandish commented Aug 17, 2023

This issue, Has been solved. #5722
And in my extensive tests, I discovered that most of the problems related to RTL performance are also solved, like this issue.
I checked my code compatibility in multiple environments and browsers and faced no problems or issues.
A CSS hack was used to hide the input, and I used a much simpler way to achieve that.

@changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2023

⚠️ No Changeset found

Latest commit: 0c7a237

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 17, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0c7a237:

Sandbox Source
react-codesandboxer-example Configuration

@MiladKarandish MiladKarandish changed the title In DummyInput.tsx, Input CSS hack replaced with improved and efficient code. In DummyInput.tsx, Input CSS hack replaced with improved and efficient code. https://github.com/JedWatson/react-select/issues/5722 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants