Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unset enabled Input visibility #5618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petrkrulis
Copy link

Enabled Input should not have visibility: 'visible' settings. The goal is just to hide it when disabled and don't do anything special when Input is in enabled state.

Visibility is one of those CSS props, which can override parent's settings. It doesn't behave the same as display would. Therefore, you cannot effectively hide it.

Example:

<div style={{visibility: 'hidden'}}> 
    <div style={{visibility: 'visible'}}>
        This is visible. Child style overrides parent style. 
    </div> 
</div> 

Solution is to use the unset value.

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2023

⚠️ No Changeset found

Latest commit: 0dadb41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0dadb41:

Sandbox Source
react-codesandboxer-example Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant