Fix re-focus of component in Firefox if being disabled while focused #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb6393d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb6393d:
|
Rall3n
changed the title
Rall3n
force-pushed
the
fix-firefox-refocus
branch
from
f680e41
to
8b70dc1
Compare
aesy
approved these changes
Jul 28, 2022
Rall3n
force-pushed
the
fix-firefox-refocus
branch
2 times, most recently
from
6ddc027
to
8a03600
Compare
lukebennett88
approved these changes
Oct 24, 2022
Rall3n
force-pushed
the
fix-firefox-refocus
branch
from
8a03600
to
cb6393d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4906.
As explained in #4906 (comment), Firefox does not fire blur if component becomes disabled while focused.
When re-enabling, Firefox by default re-focuses the component without firing the focus event, causing in the focused state not being properly set.
This PR fixes this behavior by setting
isFocusedstate if component was previously disabled and ifinputRefis currently active element.