Make "MenuPlacer" component customizable and switchable. #5167
Conversation
🦋 Changeset detectedLatest commit: ea25ad2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ea25ad2:
|
kkamik
force-pushed
the
master
branch
2 times, most recently
from
d11e9a6
to
3de79ec
Compare
|
LGTM |
|
Good for me also 👍 |
|
@Rall3n @Methuselah96 Could you review PR? |
|
To be clear, it seems like the issue you're describing is actually a bug, is that correct? Would using the height of the scroll parent when the menu is not using fixed positioning (like this) work for you? If so, I wonder if it would be better to merge specifically that change since it seems like an improvement to the status quo while we still work on more fully fixing menu positioning by switching to Popper. |
Correct.
I guess it can help.
@Methuselah96 So, let's merge it :) |
I need to redefine the component "MenuPlacer" because I have issue with viewHeight
https://github.com/JedWatson/react-select/blob/master/packages/react-select/src/components/Menu.tsx#L78
In my case, the Select component renders inside scrollable container that have 50vh, and
const viewHeight = window.innerHeightis a problem for my case.I think make customizable MenuPlacer is the easiest way to fix it.