Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid referencing an ID that is not in the DOM #5131

Merged
merged 3 commits into from Apr 10, 2022
Merged

Avoid referencing an ID that is not in the DOM #5131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87437cb
Avoid referencing an ID that is not in the DOM
pcorpet Mar 31, 2022
0c953ff
Merge branch 'master' into master
Methuselah96 Apr 10, 2022
b5507b7
Update curly-mice-nail.md
Methuselah96 Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curly-mice-nail.md
View file
Open in desktop
@@ -0,0 +1,5 @@
---
'react-select': patch
---

Avoid referencing an ID that is not in the DOM
6 changes: 4 additions & 2 deletions packages/react-select/src/Select.tsx
View file
Open in desktop
Expand Up @@ -1560,13 +1560,15 @@ export default class Select<
'aria-autocomplete': 'list' as const,
'aria-expanded': menuIsOpen,
'aria-haspopup': true,
'aria-controls': this.getElementId('listbox'),
'aria-owns': this.getElementId('listbox'),
'aria-errormessage': this.props['aria-errormessage'],
'aria-invalid': this.props['aria-invalid'],
'aria-label': this.props['aria-label'],
'aria-labelledby': this.props['aria-labelledby'],
role: 'combobox',
...(menuIsOpen && {
'aria-controls': this.getElementId('listbox'),
'aria-owns': this.getElementId('listbox'),
}),
...(!isSearchable && {
'aria-readonly': true,
}),
Expand Down
2 changes: 0 additions & 2 deletions packages/react-select/src/__tests__/__snapshots__/Async.test.tsx.snap
View file
Open in desktop
Expand Up @@ -193,11 +193,9 @@ exports[`defaults - snapshot 1`] = `
>
<input
aria-autocomplete="list"
aria-controls="react-select-2-listbox"
aria-describedby="react-select-2-placeholder"
aria-expanded="false"
aria-haspopup="true"
aria-owns="react-select-2-listbox"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down
2 changes: 0 additions & 2 deletions packages/react-select/src/__tests__/__snapshots__/AsyncCreatable.test.tsx.snap
View file
Open in desktop
Expand Up @@ -193,11 +193,9 @@ exports[`defaults - snapshot 1`] = `
>
<input
aria-autocomplete="list"
aria-controls="react-select-2-listbox"
aria-describedby="react-select-2-placeholder"
aria-expanded="false"
aria-haspopup="true"
aria-owns="react-select-2-listbox"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down
2 changes: 0 additions & 2 deletions packages/react-select/src/__tests__/__snapshots__/Creatable.test.tsx.snap
View file
Open in desktop
Expand Up @@ -193,11 +193,9 @@ exports[`defaults - snapshot 1`] = `
>
<input
aria-autocomplete="list"
aria-controls="react-select-2-listbox"
aria-describedby="react-select-2-placeholder"
aria-expanded="false"
aria-haspopup="true"
aria-owns="react-select-2-listbox"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down
2 changes: 0 additions & 2 deletions packages/react-select/src/__tests__/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Expand Up @@ -193,11 +193,9 @@ exports[`snapshot - defaults 1`] = `
>
<input
aria-autocomplete="list"
aria-controls="react-select-2-listbox"
aria-describedby="react-select-2-placeholder"
aria-expanded="false"
aria-haspopup="true"
aria-owns="react-select-2-listbox"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down
2 changes: 0 additions & 2 deletions packages/react-select/src/__tests__/__snapshots__/StateManaged.test.tsx.snap
View file
Open in desktop
Expand Up @@ -193,11 +193,9 @@ exports[`defaults > snapshot 1`] = `
>
<input
aria-autocomplete="list"
aria-controls="react-select-2-listbox"
aria-describedby="react-select-2-placeholder"
aria-expanded="false"
aria-haspopup="true"
aria-owns="react-select-2-listbox"
autocapitalize="none"
autocomplete="off"
autocorrect="off"
Expand Down