Move emotion packages and types for react-transition-group to peerDependencies

[uzikilon]

This PR is a suggestion to move emotion to "peerDependencies" avoid conflict with apps running other version of emotion

[changeset-bot]

🦋 Changeset detected

Latest commit: 2172f7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
react-select	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2172f7f:

Sandbox	Source
react-codesandboxer-example	Configuration

[weedz]

This will also close #4962 as it moves @types/react-transition-group to devDependencies 👍

[kauffmanes]

There's a bug in emotion that caused useInsertionEffect to be referenced directly in the specifiers list of the import statement. I was going to open a bug to update the version of emotion but I think this issue would take care of that problem as well?

emotion-js/emotion#2649
emotion-js/emotion#2651
https://stackoverflow.com/questions/71185635/material-ui-export-useinsertioneffect-imported-as-useinsertioneffect1-was

[nderkim]

Is it still patch if a dependency has been moved to peerDependencies?

[lukebennett88]

Code that ships to the user has been changed, but it doesn't add any new functionality (minor) or change the existing API (major), so I'd consider it a patch (unless I'm missing something?)

[nderkim]

They might not already have emotion explicitly added as a dependency in their application, so wouldn't it be a potentially breaking change?

[lukebennett88]

Thats a good point.
I think it varies by package manager, so it definitely could be a breaking change for a subset of users. I'll try to find someone who can give us a definitive answer 👍

This PR introduces a breaking change

[lukebennett88]

Thanks so much for your PR @uzikilon.
Unfortunately this is a breaking change so we can't merge it until we're ready to do another major release.

[sorenhoyer]

In my opinion runtime css-in-js is the real problem here. Many have already started using zero-runtime css-in-js such as Linaria, and tbh I don't think the consumer who opted out of these messy libraries (emotion, styled-components etc.) should pay the price by having such a library installed and included in their code neither implicit nor explicitly,

So instead of asking the question whether it should be a peer- or normal dependency, perhaps there should be a PR for migrating away from using runtime css-in-js in the first place?

[Methuselah96]

See #5451 for discussion regarding decoupling from Emotion.