Use React's AriaAttributes type directly rather than recreating
#4941
Conversation
🦋 Changeset detectedLatest commit: e760921 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e760921:
|
packages/react-select/src/Select.tsx
Outdated
| @@ -76,7 +77,7 @@ export interface Props< | |||
| /** HTML ID of an element containing an error message related to the input**/ | |||
| 'aria-errormessage'?: string; | |||
| /** Indicate if the value entered in the field is invalid **/ | |||
| 'aria-invalid'?: boolean; | |||
| 'aria-invalid'?: AriaInvalid; | |||
There was a problem hiding this comment.
Instead of redefining AriaInvalid, can we do AriaAttributes['aria-invalid'] here (and import AriaAtributes from react)?
There was a problem hiding this comment.
Yeah, definitely. I'll make that change now
There was a problem hiding this comment.
Do you think it's worth updating the other aria attributes to pull from that type for the sake of consistency? @Methuselah96
There was a problem hiding this comment.
If you're up for that, that would be great. Thanks!
prichey
changed the title
AriaAttributes directly rather than recreating
prichey
changed the title
AriaAttributes directly rather than recreatingAriaAttributes type directly rather than recreating
|
@Methuselah96 took the liberty to update the only other place we were recreating types from |
|
Thanks! Forgot to ask earlier: can you add a changeset? |
|
@Methuselah96 Just added one - let me know if I did it correctly, this was my first time using that package |
|
Yeah, looks good. |
|
@Methuselah96 How do you determine when to cut a new release? It'd be nice to upgrade without having to do my own manual patching. Thanks! |
|
@prichey Thanks for the reminder, as you can see we haven't been doing a whole lot of merging/releasing recently. I'll try to get a release out soon. I noticed you classified this as a minor change instead of a patch. Any particular reason? |
|
@Methuselah96 No problem! Tbh it could totally be a patch, I think I did that after you had tagged it with 5.3 so I assumed you wanted it to be a minor release. Patch would be awesome if that helps it get released! |
|
Excellent, thanks!
…On Thu, Jan 13, 2022 at 1:22 PM Nathan Bierema ***@***.***> wrote:
@prichey <https://github.com/prichey> Published in v5.2.2
<https://github.com/JedWatson/react-select/releases/tag/react-select%405.2.2>
.
—
Reply to this email directly, view it on GitHub
<#4941 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK2J5YBLB653MPBLYWD5UDUV4J5FANCNFSM5JPKNQ6A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixes #4940