Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser alias fields #4423

Merged

Conversation

Methuselah96
Copy link
Collaborator

@Methuselah96 Methuselah96 commented Feb 5, 2021

Resolves #3802.

The browser alias outputs aren't doing much anyway besides causing the bug in SSR (they just remove the typeof window !== undefined check in one place), so I think it practically makes sense to remove them even though we're technically doing everything correctly.

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2021

🦋 Changeset detected

Latest commit: b8f9ec7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8f9ec7:

Sandbox Source
react-codesandboxer-example Configuration

@JedWatson
Copy link
Owner

@mitchellhamilton do you know anything about this that would make this PR not the best way forward?

@emmatown
Copy link
Collaborator

emmatown commented Feb 9, 2021

There's nothing really wrong with merging this PR since in this case, the browser builds are pointless. react-select depends on emotion though and emotion has browser builds which have a non-trivial bundle size saving so this change won't really solve the problem for people.

@Methuselah96
Copy link
Collaborator Author

Methuselah96 commented Feb 10, 2021

True. I've added a concluding comment to the linked issue.

@JedWatson Up to you whether this is worth merging. The benefit of merging it would be that it would then definitely not be our problem and we could tell people to bug Emotion, their SSR library, and/or Webpack instead of bugging us. The browser builds for react-select (as Mitchell pointed) are currently pointless.

@JedWatson JedWatson enabled auto-merge March 4, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScrollLock dist missing window undefined check
3 participants