Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto focus disabled with a new prop #3324

Closed
wants to merge 1 commit into from
Closed

Auto focus disabled with a new prop #3324

wants to merge 1 commit into from

Conversation

mnpreetkaur
Copy link

#2848 #3061
Above issues could be resolved with this enhancement

@gwyneplaine I've added a new prop disableAutoFocus, which allows deactivation of auto focus of first or any option on opening of the option menu.

@scsjonatan
Copy link

Somebody know if this PR is going to be merged?
I really need this feature.

@vueme
Copy link

vueme commented Jan 21, 2019

This functionality would be really cool! Waiting for this as well.

@szklanko
Copy link

This is really helpful feature. Please merg

DragorWW
DragorWW reviewed Jan 29, 2019
View reviewed changes
src/Select.js
@@ -487,7 +487,7 @@ export default class Select extends Component<Props, State> {

openMenu(focusOption: 'first' | 'last') {
const { menuOptions, selectValue } = this.state;
const { isMulti } = this.props;
const { isMulti, disableAutoFocus } = this.props;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed flow type

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even the documentation is missing but I needed a confirmation if they're willing to merge this new feature.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge please.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is now a conflict in this merge request

@Ziker22
Copy link

Ziker22 commented Mar 27, 2019

Guys im waiting for this is there something i can help with to speed up actuall merge ?

@danishmughal
Copy link

This would be great to have! Waiting for this to get merged in...

@austinderek
Copy link

Waiting for this....

@roblopz
Copy link

roblopz commented May 4, 2019

Waiting too...

@D1verGW
Copy link

D1verGW commented May 28, 2019

Waiting for this. Merge please.

@Gsiete
Copy link

Gsiete commented Jun 3, 2019

The naming seems to clash conceptually with the autoFocus prop

@elnazabo
Copy link

elnazabo commented Jun 12, 2019 •
edited

Any chances this could be merged in the near future! 🙏
Is very similar to #3484

@elnazabo elnazabo mentioned this pull request Jun 17, 2019
Closed
@Francismb Francismb mentioned this pull request Aug 5, 2019
Closed
@ismaildervisoglu
Copy link

Waiting for this. Merge please.

@iamnnort
Copy link

iamnnort commented Oct 1, 2019

Hi, any news about the prop disableAutoFocus?

@zgallagher08
Copy link

I'm also running into this issue. On mobile it is an issue especially because there is no cursor to change the highlighted option.

Hoping this merges asap.

@alexandr-bbm
Copy link

alexandr-bbm commented Nov 15, 2019 •
edited

Hey @mnpreetkaur, can you please resolve the conflicts?

@JedWatson @gwyneplaine @bvaughn @mitchellhamilton
Dear maintainers there are 3 similar open PRs about the mentioned property. Can you please help to proceed with some of them to stop people having forks and having something like this in their repos (pic below)?

image

@miketdonahue
Copy link

@mnpreetkaur @JedWatson @gwyneplaine @bvaughn @mitchellhamilton

Would be awesome to get this merged!

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome pr/priority PRs that should be addressed sooner rather than later labels May 27, 2020
@bladey
Copy link
Contributor

bladey commented Jun 5, 2020

Hey @mnpreetkaur, could you please resolve any conflicts and provide a CodeSandbox of this PR with a working example? I'd like to test and get this merged.

@bladey bladey added awaiting-author-response Issues or PRs waiting for more information from the author and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Jun 5, 2020
@bladey
Copy link
Contributor

bladey commented Jun 10, 2020

Hi all,

Thanks for your contribution @mnpreetkaur!

There are a number of pull requests adding this feature - I've since created an up to date PR - #4080, and closed similar pull requests.

If I've missed anything, please let me know.

Closing this PR in favor of #4080.

@bladey bladey closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DragorWW DragorWW DragorWW left review comments

@stigmat4j stigmat4j stigmat4j left review comments

@alisonhall alisonhall alisonhall left review comments

@atishjain29100 atishjain29100 atishjain29100 approved these changes

Assignees
No one assigned
Labels
awaiting-author-response Issues or PRs waiting for more information from the author pr/priority PRs that should be addressed sooner rather than later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet