Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix the focus behaviour with react-select and react-datepicker #1946

Closed
wants to merge 2 commits into from
Closed

Conversation

nothingrandom
Copy link

In reference to #1539 and Hacker0x01/react-datepicker#730

This is an imperfect fix to the bug. It needs further work and suggestions, open to hearing what that might be.

@JedWatson
Copy link
Owner

Hey @nothingrandom, thanks for the PR 👍

Some quick feedback on it - if you click the "files changed" tab you'll see that all the indentation has changed, which makes it really hard to see what the actual intended change is here. You could also avoid creating a reference to self by using an arrow function in the timeout: () => { ... } and I'm not sure what the value of creating a second reference to evt is.

Also, please only submit changes to the src folder 🙂

With that in mind, I'm trying to sort out as many PRs as possible so I'm going to close this one. I've had a look at react-datepicker and I think the solution may be a change in that component (it's re-focusing in a timeout after any blur from what I can tell) and we would need to understand the impact of removing the .preventDefault() here before this could be merged.

If we can't find a solution in react-datepicker I'm open to looking at ways to change react-select but let's see if we can solve it there first.

@JedWatson JedWatson closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants