AbstractAcceptanceTest integrationtest fix for vs2019 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the new vs2019 (16.2.0) test explorer has an issue with GetAssemblies when it tries to load internal test assemblies microsoft/vstest#2008 with this fix the Microsoft assemblies are not loaded when an integration test runs (FunctionMonkey.Testing.AbstractAcceptanceTest)
| @@ -40,7 +40,7 @@ public static IFunctionAppConfiguration FindConfiguration() | |||
|
|
|||
| private static bool Scan(out MethodInfo linkBackInfo, out IFunctionAppConfiguration findConfiguration) | |||
| { | |||
| Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies(); | |||
| Assembly[] assemblies = AppDomain.CurrentDomain.GetAssemblies().Where(a => !a.GetName().Name.StartsWith("Microsoft.")).ToArray(); | |||
There was a problem hiding this comment.
Is it safe to further qualify the Microsoft. prefix - Microsoft.VisualStudio perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new vs2019 (16.2.0) test explorer has an issue with GetAssemblies when it tries to load internal test assemblies
microsoft/vstest#2008
with this fix the Microsoft assemblies are not loaded when an integration test runs (FunctionMonkey.Testing.AbstractAcceptanceTest)