Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newtonsoft.Json version and property names in ConvertErrors task #116

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lars-erik
Copy link

Disclaimer: Only trying the 4 beta, so you might be on top of this. But I had to do it in order to get to publish.
I've managed to make the compile step "work" in VS19 by manually copying in the assembly with this changes to the %user%.nuget\… folder.
However, dotnet CLI and VS publish still fails for weird reasons. Seems it still can't find Newtonsoft.Json 12.
In order to get anything through, I comment out the ConvertErrors steps in the build targets file for now.

Shout if you want some logs, but it's really just "Can't find Newtonsoft.Json 12". ;)

@lars-erik
Copy link
Author

Here's the project and deps file that I had problems with.
The actual functions are in the referenced "MarkedsPartner.Middleware.Identity" package.
Only thing actually being compiled in the function project itself is the FunctionAppConfiguration.
Here's the files:

https://gist.github.com/lars-erik/122893e4c5ce0edec0d376a79a93a785

(OpenApiSpecVersion and Format is another PR, but not sure it's needed yet)

@lars-erik
Copy link
Author

lars-erik commented Jan 23, 2020

On a side note, I resolved this type of exception in another project by adding a handler to AppDomain.AssemblyResolve. Might be the way to go instead.

(BTW, the beta is now in production at ours'… ;) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant