Fixed XElement serialization with explicit empty namespace. #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
May 28, 2022
MagMar94
force-pushed
the
magmar94/fix-xelement-serialization
branch
from
a7f67fa
to
274cd24
Compare
When a child node has an explicit empty namespace, it should not be serialized with the namespace of the parent node.
MagMar94
force-pushed
the
magmar94/fix-xelement-serialization
branch
from
274cd24
to
3220ca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2681
When an
XElementchild node has an explicit empty namespace, it should not be serialized with the namespace of the parent node. The child should have"@xmlns": "".