Skip to content

Commit

Permalink
Move debug symbols to symbol package (#2051)
Browse files Browse the repository at this point in the history
  • Loading branch information
JamesNK committed Apr 21, 2019
1 parent b34a3cc commit 5416cd4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions Build/build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ task Package -depends Build {

mkdir $workingDir\NuGet
move -Path $sourceDir\Newtonsoft.Json\bin\Release\*.nupkg -Destination $workingDir\NuGet
move -Path $sourceDir\Newtonsoft.Json\bin\Release\*.snupkg -Destination $workingDir\NuGet
}

Write-Host "Build documentation: $buildDocumentation"
Expand Down
6 changes: 3 additions & 3 deletions Src/Newtonsoft.Json/Newtonsoft.Json.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@
<AssemblyName>Newtonsoft.Json</AssemblyName>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<MinClientVersion>2.12</MinClientVersion>
<!-- including PDB files in NuGet for source link because symbolsource.org does not support portable PDBs -->
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
</PropertyGroup>
<ItemGroup>
<None Remove="**\*.orig" />
<None Include="..\..\LICENSE.md" Pack="true" PackagePath="LICENSE.md" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta-63127-02" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0-beta2-18618-05" PrivateAssets="All" />
</ItemGroup>
<PropertyGroup Condition="'$(TargetFramework)'=='net45'">
<AssemblyTitle>Json.NET</AssemblyTitle>
Expand Down

3 comments on commit 5416cd4

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you uploaded the package? I don't get the symbols for 12.0.2 in vs2017 even if I add nuget symbol server to VS options.

@JamesNK
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicAndre1981
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I expended the file to the folder structure in .nuget folder and manually added the pdb

Please sign in to comment.