Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

New: Support unknown keyword #3

Merged
merged 3 commits into from Sep 26, 2018
Merged

New: Support unknown keyword #3

merged 3 commits into from Sep 26, 2018

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Sep 24, 2018

This PR adds support for unknown keyword which is since TypeScript 3.0.

Note that the test will be failed when comparing to Babylon's AST, because Babylon doesn't support unknown as a keyword so far. Here is the related PR: babel/babel#8755

@g-plane g-plane changed the title Support unknown keyword New: Support unknown keyword Sep 24, 2018
@JamesHenry
Copy link
Owner

JamesHenry commented Sep 24, 2018

Thanks, @g-plane! You can add an ignore for the new spec (to remove it from the ast-alignment-tests), see this file for how we currently do that: https://github.com/JamesHenry/typescript-estree/blob/master/tests/ast-alignment/fixtures-to-test.js#L342

@g-plane
Copy link
Contributor Author

g-plane commented Sep 25, 2018

Updated.

Copy link
Owner

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @g-plane!

@JamesHenry JamesHenry merged commit 0518ec2 into JamesHenry:master Sep 26, 2018
JamesHenry pushed a commit that referenced this pull request Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants