Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make downloads working better for Debian and macOS users #2359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 25, 2024

Users with a recent Mac (starting from the M1 machines) get the wrong macOS binary. Therefore, raising issues in JabRef repo again and again and binding our spare development resources. - Example: JabRef/jabref#11082

The underlying issue is #2176. There was a fix attempt made (#2176 (comment)), but it was rejected in favor of a "far better" solution (#2176 (comment)). However, no one implemented this.

I perceive that we upset users and force some users to stay at old versions. Our JabRef strategy (since about 10 years) is to "force" users to update to a new version - and make this transition smooth.

Thus, we should get the "quick fix" in - and work on a "perfect" fix later on.

Fix dl button href
@koppor koppor requested a review from tobiasdiez March 25, 2024 15:22
@koppor
Copy link
Member Author

koppor commented Mar 25, 2024

Pipeline fails at the first steps:

image

OK, a PR might be considered "unsecure", but I don't understand why a branch from the same repository is considered unsecure.

@tobiasdiez
Copy link
Member

Users with a recent Mac (starting from the M1 machines) get the wrong macOS binary. Therefore, raising issues in JabRef repo again and again and binding our spare development resources. - Example: JabRef/jabref#11082

I think it would be good to detect this on the start of JabRef and report an error. Even if the download link redirects to the general fosshub page you are bound to have users that download the wrong binary.

Thus, we should get the "quick fix" in - and work on a "perfect" fix later on.

Note that this "quick fix" is a regression for everyone not having a new mac system.

If you don't want to work on the redesigned download interface (which I can understand), a "good enough" solution for now would be the following:

  • In
    export function constructDownloadUrl(): string {
    , add special handling of macos. Namely,
  • navigator.userAgent.match(/OS X 10_([789]|1[01234])/) then its not arm (since silicon exists only with 10_5 or higher)
  • navigator.userAgentData.getHighEntropyValues exists, then use it to obtain the architecture (this should work on modern chrome browsers
  • fallback to generic download url

@tobiasdiez
Copy link
Member

OK, a PR might be considered "unsecure", but I don't understand why a branch from the same repository is considered unsecure.

Good suggestion. Happy to receive a PR.

@tobiasdiez tobiasdiez added status: needs changes PR needs further changes before it can be merged type: enhancement Improving upon an existing feature labels Mar 26, 2024
@tobiasdiez tobiasdiez changed the title Make downloads working better for Debian and macOS users feat: make downloads working better for Debian and macOS users Mar 26, 2024
Copy link

@koppor
Copy link
Member Author

koppor commented Mar 26, 2024

Note that this "quick fix" is a regression for everyone not having a new mac system.

Yes, but the download used to work before. Even with a click more.

Sometimes one needs to accept a step back to get things working.

@koppor
Copy link
Member Author

koppor commented Mar 26, 2024

If you don't want to work on the redesigned download interface (which I can understand), a "good enough" solution for now would be the following:

Thank you for understanding the challenge of addressing the redesigned download interface at this moment. Our immediate focus is on supporting our GSoC students and addressing bugs in JabRef. This prioritization allows us to ensure the stability and functionality of JabRef, benefiting our user community at large.

I acknowledge the importance of the download interface and the need for a solution that does not hinder user experience or contribute to users staying on outdated versions. Our goal has always been to facilitate a seamless transition to new versions, emphasizing user satisfaction and engagement.

I am aware of the concerns regarding macOS users and the potential impact on their experience. Addressing this issue remains a priority, and we aim to implement a temporary solution promptly. A more comprehensive fix will be explored as soon as our current commitments allow for additional bandwidth.

The feedback regarding FOSShub and the observed decrease in download numbers is being taken seriously. It underscores the necessity of a swift response to maintain trust and satisfaction within our community.

We are committed to implementing a "quick fix" to immediately address the most pressing concerns, with plans to develop and apply a more refined solution in the future. Your patience and understanding as we navigate these challenges are greatly appreciated.

@Siedlerchr
Copy link
Member

Normally, x86 programs work on Mac arm as well, they just use Rosetta emulation. However, seems to be problematic with java/javafx and performance wise degraded.

And linux users will also need to choose the right one for their system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs changes PR needs further changes before it can be merged status: safe to test type: enhancement Improving upon an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants