remove some redundant fence

[hl845740757]

1. For MpscLinkedArrayQueue, producer(producerLimit) rely on consumerIndex.
2. For MpscLinkedArrayQueue, newBuffer is unreachable until soProducerIndex.
3. For SpscLinkedArrayQueue, newBuffer is unreachable until soRefElement(JUMP).
4. Fix resize assertion.
5. For MpscUnboundedXaddArrayQueue, consumer free the chunk happens-before producer reuse the chunk.

I have run related tests.

[franz1981]

Please take a look at the LGTM error:

[2020-05-29 09:27:33] [autobuild] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project jctools-core: Compilation failure: Compilation failure: 
[2020-05-29 09:27:33] [autobuild] [ERROR] /opt/src/jctools-core/src/main/java/org/jctools/queues/atomic/BaseMpscLinkedAtomicArrayQueue.java:[791,9] method spRefElement in class org.jctools.queues.atomic.AtomicQueueUtil cannot be applied to given types;
[2020-05-29 09:27:33] [autobuild] [ERROR]   required: java.util.concurrent.atomic.AtomicReferenceArray<E>,int,E
[2020-05-29 09:27:33] [autobuild] [ERROR]   found: java.util.concurrent.atomic.AtomicReferenceArray<E>,int,java.util.concurrent.atomic.AtomicReferenceArray<E>
[2020-05-29 09:27:33] [autobuild] [ERROR]   reason: inferred type does not conform to lower bound(s)
[2020-05-29 09:27:33] [autobuild] [ERROR]     inferred: E
[2020-05-29 09:27:33] [autobuild] [ERROR]     lower bound(s): java.util.concurrent.atomic.AtomicReferenceArray<E>
[2020-05-29 09:27:33] [autobuild] [ERROR] /opt/src/jctools-core/src/main/java/org/jctools/queues/atomic/BaseSpscLinkedAtomicArrayQueue.java:[247,9] method spRefElement in class org.jctools.queues.atomic.AtomicQueueUtil cannot be applied to given types;
[2020-05-29 09:27:33] [autobuild] [ERROR]   required: java.util.concurrent.atomic.AtomicReferenceArray<E>,int,E
[2020-05-29 09:27:33] [autobuild] [ERROR]   found: java.util.concurrent.atomic.AtomicReferenceArray<E>,int,java.util.concurrent.atomic.AtomicReferenceArray<E>
[2020-05-29 09:27:33] [autobuild] [ERROR]   reason: inferred type does not conform to lower bound(s)
[2020-05-29 09:27:33] [autobuild] [ERROR]     inferred: E
[2020-05-29 09:27:33] [autobuild] [ERROR]     lower bound(s): java.util.concurrent.atomic.AtomicReferenceArray<E>
[2020-05-29 09:27:33] [autobuild] [ERROR] -> [Help 1]

[hl845740757]

@franz1981 fixed

[coveralls]

Pull Request Test Coverage Report for Build 683

• 37 of 39 (94.87%) changed or added relevant lines in 6 files are covered.
• 6 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.2%) to 86.114%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
jctools-core/src/main/java/org/jctools/queues/MpscUnboundedXaddArrayQueue.java	2	3	66.67%
jctools-core/src/main/java/org/jctools/queues/atomic/BaseMpscLinkedAtomicArrayQueue.java	8	9	88.89%

Files with Coverage Reduction	New Missed Lines	%
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java	1	79.26%
jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMapLong.java	2	80.4%
jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java	3	76.81%

Totals
Change from base Build 676:	0.2%
Covered Lines:	4775
Relevant Lines:	5545

---

💛 - Coveralls

[nitsanw]

Please run build locally before submitting PRs

…

On Fri, May 29, 2020, 12:42 Coveralls ***@***.***> wrote: Pull Request Test Coverage Report for Build 678 <https://coveralls.io/builds/31114122> - *33* of *34* *(97.06%)* changed or added relevant lines in *4* files are covered. - *6* unchanged lines in *2* files lost coverage. - Overall coverage increased (+*0.1%*) to *86.091%* ------------------------------ Changes Missing Coverage Covered Lines Changed/Added Lines % jctools-core/src/main/java/org/jctools/queues/atomic/BaseMpscLinkedAtomicArrayQueue.java <https://coveralls.io/builds/31114122/source?filename=jctools-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fjctools%2Fqueues%2Fatomic%2FBaseMpscLinkedAtomicArrayQueue.java#L565> 8 9 88.89% Files with Coverage Reduction New Missed Lines % jctools-core/src/main/java/org/jctools/maps/NonBlockingHashMap.java <https://coveralls.io/builds/31114122/source?filename=jctools-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fjctools%2Fmaps%2FNonBlockingHashMap.java#L1088> 2 78.82% jctools-core/src/main/java/org/jctools/maps/NonBlockingIdentityHashMap.java <https://coveralls.io/builds/31114122/source?filename=jctools-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fjctools%2Fmaps%2FNonBlockingIdentityHashMap.java#L655> 4 75.06% Totals [image: Coverage Status] <https://coveralls.io/builds/31114122> Change from base Build 676 <https://coveralls.io/builds/31091988>: 0.1% Covered Lines: 4772 Relevant Lines: 5543 ------------------------------ 💛 - Coveralls <https://coveralls.io> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#307 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAURMLYRRXUKIV7FZFNNPRLRT6GRBANCNFSM4NN36YEA> .

[hl845740757]

@nitsanw Sorry, I forgot to run mvn build...

[hl845740757]

JCTools is a great library.
I have read the source code of all queues and will not submit new issues or prs in a short time.