Improved handling of in-progress consumer buffer rotation and simplified peek of mpmc xadd q #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include an alternative fix for #255 on a0bc103#diff-61853935c955f7d3dd424601f34d4ca1R583:
a pooled chunk element is considered "stable" right after its sequence is being written, so it can be read after winning the cas.
There are other improvements/fixes in this PR:
rotateConsumerBuffer
is responsible to awaitnext
to be visible after winning the cas (on a0bc103#diff-61853935c955f7d3dd424601f34d4ca1R443) with no fear to get interruped by other consumers (on a0bc103#diff-61853935c955f7d3dd424601f34d4ca1L612)NOTE: #265 could be solved by incorporating some of the changes on this PR