updated normalize-url dependency #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing #19
|
@IonicaBizau Any updates on this? |
|
This PR breaks Safari because normalize-url@6 includes regular expressions that cannot be parsed by Safari. Maybe it's worth a major release? |
|
Hey sorry! This is causing errors in the browser for us at backstage/backstage#6039. The library recommends using the |
|
@OrkoHunter I could try to release another patch downgrading the version and then a major release to upgrade it back. Would that work? Sorry for the late reply... I was sick last week. 🤧 |
|
That definitely works! @IonicaBizau And hey, no worries ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #19