Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used better version comparison lib #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

BrainStone
Copy link

I rewrote a small part so that it uses a better library to compare the versions.

See: https://github.com/AuraDevelopmentTeam/VersionLib

@BrainStone
Copy link
Author

As a note, it is building locally. No clue why it's having issues with travis

@Th3Shadowbroker
Copy link

Th3Shadowbroker commented Feb 25, 2019

It looks like VersionLib isn't registered at maven-central. According to travis-ci-log:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.0.0-M1:aggregate (default-cli) on project parent: An error has occurred in Javadoc report generation: org.eclipse.aether.resolution.DependencyResolutionException: Could not find artifact dev.aura.lib.version:VersionLib:jar:1.0.1.25 in central (https://repo.maven.apache.org/maven2) -> [Help 1]

and I'm getting no response from the repository-server you've added to pom.xml and as far as I know you're not allowed to use spaces within the repository id.

Edit: Haven't seen this PR is 2 years old XD

@BrainStone
Copy link
Author

Oh boy. I intended to have it on maven central. Never got it there because the namespace I was using was not available at the time. I'm hosting it on my private maven however. And I'll rework the the PR to use the latest version there. Probably today.

@BrainStone
Copy link
Author

BrainStone commented Feb 25, 2019

And the failing Travis is not my problem. I'd recommend to just use mvn package as that will build without deploying to your maven.

Ready to merge btw.

@InventivetalentDev
Copy link
Owner

I'm honestly not too keen on merging this anyway, as it does remove stuff that is used by plugins, sorry.

@BrainStone
Copy link
Author

Alright. Let me add the stuff back as depcrecated and without implementation ;)

then it won't break plugins but still has the same has the better comparision.

@BrainStone
Copy link
Author

I'd recommend bumping the version to 1.5.0 to indicate the change in the version too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants