Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix decoding error with Imagick driver #1262

Merged
merged 2 commits into from Jan 14, 2024
+6 −1
Merged

Fix decoding error with Imagick driver #1262

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e4afd5
Fix decoding error with Imagick driver
olivervogel Jan 10, 2024
f3cef58
Change bugfix description comment
olivervogel Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Drivers/Imagick/Decoders/BinaryImageDecoder.php
View file
Open in desktop
Expand Up @@ -29,7 +29,12 @@ public function decode(mixed $input): ImageInterface|ColorInterface
throw new DecoderException('Unable to decode input');
}

$imagick = $imagick->coalesceImages();
// For some JPEG formats, the "coalesceImages()" call leads to an image
// completely filled with background color. The logic behind this is
// incomprehensible for me; could be an imagick bug.
if ($imagick->getImageFormat() != 'JPEG') {
$imagick = $imagick->coalesceImages();
}

// fix image orientation
switch ($imagick->getImageOrientation()) {
Expand Down