[Node.js] Add marked 0.3.9 as dependency as security vulnerability workaround #985

tingshao · 2018-01-09T05:55:32Z

The manually added dependency is to force to use the secure version before
jsdoc released its secure version.

…rkaround The security issue is jsdoc/jsdoc#1489 The manually added dependency is to force to use the secure version before jsdoc released its secure version.

halton

LGTM and approve.

tingshao · 2018-01-09T06:57:05Z

@dorodnic @halton This impacted package was only used when generating document after build the node.js module and not used during application running. So may not have much impact on our functionality. And we can remove the workaround after jsdoc updated for this.

[Node.js] Add marked 0.3.9 as dependency as security vulnerability wo…

d1fbeae

…rkaround The security issue is jsdoc/jsdoc#1489 The manually added dependency is to force to use the secure version before jsdoc released its secure version.

halton approved these changes Jan 9, 2018

View reviewed changes

halton merged commit 64f9c20 into IntelRealSense:development Jan 9, 2018

tingshao deleted the update_marked_version branch January 9, 2018 08:49

zivsha added the node.js label Jan 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Node.js] Add marked 0.3.9 as dependency as security vulnerability workaround #985

[Node.js] Add marked 0.3.9 as dependency as security vulnerability workaround #985

tingshao commented Jan 9, 2018

halton left a comment

tingshao commented Jan 9, 2018

[Node.js] Add marked 0.3.9 as dependency as security vulnerability workaround #985

[Node.js] Add marked 0.3.9 as dependency as security vulnerability workaround #985

Conversation

tingshao commented Jan 9, 2018

halton left a comment

Choose a reason for hiding this comment

tingshao commented Jan 9, 2018