1810 fix #1825

emilydriano · 2022-08-25T19:47:36Z

Addresses core issues of #1810
This PR incorporates id-generation plugins for item ID's. The name of the plugin the user desires to use can be specified in the .ini file under [COMMON] > 'id_generator'. The 2 plugins we defined are:

uuid: returns a uuid as the item id (default option)
item_sequence: returns a sequential id for the respective item based on the most recently created/used id for that respective item type. A sequence file is created that keeps track of these sequential ids for each item type (experiment, simulation, etc) and returns and stores the next id. The user can customize both the sequence file name as well as the id string format using the 'sequence_file' and 'id_format_str' options under an [item_sequence] section in the .ini file. See added docs for more detail and an example.

Documentation and tests were also added for this feature.

*Note - the id sequential generator plugin is intended to be used with Slurm, not with COMPS.

To support this, we also added tickets related
#1930
#1936
#1937
#1938
#1939
#1954

idmtools_core/tests/test_item_sequence.py

shchen-idmod · 2022-08-29T20:41:29Z

My test take forever with script below and eventual throw error:

    def test_perf(self):
       
        parser = IdmConfigParser()
        parser._load_config_file(file_name='idmtools_slurm.ini')
        task = JSONConfiguredPythonTask(script_path=os.path.join(COMMON_INPUT_PATH, "python", "model3.py"),
                                        envelope="parameters", parameters=(dict(c=0)))
        platform = Platform('SLURM_TEST')
        ts = TemplatedSimulations(base_task=task)
        e = Experiment.from_template(ts)
        from idmtools.builders import SimulationBuilder
        builder = SimulationBuilder()

        def param_update(simulation, param, value):
            return simulation.task.set_parameter(param, value)
        builder.add_sweep_definition(partial(param_update, param="a"), range(300))
        builder.add_sweep_definition(partial(param_update, param="b"), range(500))
        e.simulations.add_builder(builder)
        suite = add_dammy_suite(e)
        suite.run(platform=platform, dry_run=True)

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\idmtools\core\interfaces\irunnable_entity.py:104: in run
    p.run_items(self, wait_on_done_progress=wait_on_done_progress, **run_opts)
..\idmtools\entities\iplatform.py:507: in run_items
    getattr(self, interface).run_item(item, **kwargs)
..\idmtools\entities\iplatform_ops\iplatform_suite_operations.py:193: in run_item
    self.pre_run_item(suite, **kwargs)
..\idmtools\entities\iplatform_ops\iplatform_suite_operations.py:165: in pre_run_item
    self.platform.run_items(exps_to_commission, **kwargs)
..\idmtools\entities\iplatform.py:507: in run_items
    getattr(self, interface).run_item(item, **kwargs)
..\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:260: in run_item
    self.pre_run_item(experiment, **kwargs)
..\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:225: in pre_run_item
    experiment.simulations = self.platform._create_items_of_type(experiment.simulations, ItemType.SIMULATION, **kwargs)
..\idmtools\entities\iplatform.py:469: in _create_items_of_type
    ni = getattr(self, interface).batch_create(items, **kwargs)
..\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:134: in batch_create
    return batch_create_items(sims, create_func=self.create, display_progress=display_progress,
..\idmtools\entities\iplatform_ops\utils.py:151: in batch_create_items
    results = show_progress_of_batch(prog, futures)
..\idmtools\entities\iplatform_ops\utils.py:172: in show_progress_of_batch
    result = future.result()
c:\python39\lib\concurrent\futures\_base.py:438: in result
    return self.__get_result()
c:\python39\lib\concurrent\futures\_base.py:390: in __get_result
    raise self._exception
c:\python39\lib\concurrent\futures\thread.py:52: in run
    result = self.fn(*self.args, **self.kwargs)
..\idmtools\entities\iplatform_ops\utils.py:61: in item_batch_worker_thread
    ret.append(create_func(item, **kwargs))
..\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:99: in create
    simulation._platform_object = self.platform_create(simulation, **kwargs)
..\..\idmtools_platform_slurm\idmtools_platform_slurm\platform_operations\simulation_operations.py:56: in platform_create
    if not isinstance(simulation.uid, UUID):
..\idmtools\core\interfaces\iitem.py:51: in uid
    self._uid = plugin.idmtools_generate_id(self)
..\idmtools\plugins\item_sequence.py:58: in idmtools_generate_id
    data = load_existing_sequence_data(sequence_file)
..\idmtools\plugins\item_sequence.py:40: in load_existing_sequence_data
    data = json.load(file)
c:\python39\lib\json\__init__.py:293: in load
    return loads(fp.read(),
c:\python39\lib\json\__init__.py:346: in loads
    return _default_decoder.decode(s)
c:\python39\lib\json\decoder.py:337: in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <json.decoder.JSONDecoder object at 0x0000018F58CE05B0>, s = '', idx = 0

    def raw_decode(self, s, idx=0):
        """Decode a JSON document from ``s`` (a ``str`` beginning with
        a JSON document) and return a 2-tuple of the Python
        representation and the index in ``s`` where the document ended.
    
        This can be used to decode a JSON document from a string that may
        have extraneous data at the end.
    
        """
        try:
            obj, end = self.scan_once(s, idx)
        except StopIteration as err:
>           raise JSONDecodeError("Expecting value", s, err.value) from None
E           json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

c:\python39\lib\json\decoder.py:355: JSONDecodeError

idmtools_slurm.ini:

[COMMON]
id_generator = item_sequence

[SLURM_TEST]
type = Slurm
job_directory = DEST
mode = LOCAL

[item_sequence]
sequence_file = item_sequences.json
id_format_str = {item_name}{data[item_name]:06d}

shchen-idmod · 2022-08-30T00:41:39Z

test_id.py.txt
For above test (remove .txt)

I print simulation.id before and after call run. then print different format:
Before run
Simulation000000
Simulation000001
Simulation000002
Simulation000003
Simulation000004
Simulation000005
Simulation000006
Simulation000007
Simulation000008
None
After run
b5d6f315-53a4-4a07-a28f-25036f3c3897
a9ab64a4-ba19-42aa-a885-cc7bbd506c2a
72874eb6-bb8e-4f3a-93fd-aef0d71a630d
7a7e498e-8028-47e5-9d19-f8a280a268ed
988560d6-a132-4693-b211-8690e5119c2e
a34940f7-787a-434b-9514-547f842450db
ee2c6967-46c8-48e9-ab0d-3b2828941004
619d3914-f191-4be0-8b54-6ceadb942ae0
e3c0561a-9e41-4fd5-9563-1a100e5f6686
Also item_sequences.json says simulation is 26. I only generate 9 sims.
{"Unknown": 0, "Simulation": 26, "Experiment": 0, "Suite": 0}
There is "Unknown" which I do not know where it come from

I kind of know where 26 come from:
a) If I comment out last 4 lines of code(starting from suite.run), then sequences seems correct as Simulation: 8(0 base, so total is 9).
b) If I only comment out first print statement for id, [print(sim.id) for sim in simulations], then sequence count says 17(which is 8 + 9=17). It obvious should not add another 9.
c) If I do not comment out anything, it is 26=8+9+9 which added another 9 by calling sim.id 9 times in print statement

…d on Sharon's feedback

* Ensure slurm uses uuid

* add configuration caching for id generation * add performance test scaler

…fig contraints

…sequence code.

…platform_analysis tests

shchen-idmod · 2022-09-07T04:11:35Z

test_1.py.txt

idmtools_1.ini
[COMMON]
id_generator = item_sequence

[MTest]
type = Slurm

[item_sequence]
sequence_file = item_sequences.json
id_format_str = {item_name}{data[item_name]:06d}

Get following Assets error in first run

test_1.py::TestItemSequence::test_1 FAILED                               [100%]2022-09-06 23:56:11,551 BMGF-R913QDCE idmtools.config.idm_config_parser[2116] DEBUG Looking for config file in C:\Users\sharonch\github\idmtools\idmtools_platform_slurm\tests
You are using a development version of idmtools, version 1.6.7+nightly!
INI File Used: C:\Users\sharonch\github\idmtools\idmtools_platform_slurm\tests\idmtools_1.ini

[MTest]
{
   "type": "Slurm"
}
...
test_1.py:68: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\..\idmtools_core\idmtools\entities\experiment.py:544: in run
    p.run_items(self, **run_opts)
..\..\idmtools_core\idmtools\entities\iplatform.py:507: in run_items
    getattr(self, interface).run_item(item, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:260: in run_item
    self.pre_run_item(experiment, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:225: in pre_run_item
    experiment.simulations = self.platform._create_items_of_type(experiment.simulations, ItemType.SIMULATION, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform.py:469: in _create_items_of_type
    ni = getattr(self, interface).batch_create(items, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:134: in batch_create
    return batch_create_items(sims, create_func=self.create, display_progress=display_progress,
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:151: in batch_create_items
    results = show_progress_of_batch(prog, futures)
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:172: in show_progress_of_batch
    result = future.result()
c:\python39\lib\concurrent\futures\_base.py:438: in result
    return self.__get_result()
c:\python39\lib\concurrent\futures\_base.py:390: in __get_result
    raise self._exception
c:\python39\lib\concurrent\futures\thread.py:52: in run
    result = self.fn(*self.args, **self.kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:61: in item_batch_worker_thread
    ret.append(create_func(item, **kwargs))
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:99: in create
    simulation._platform_object = self.platform_create(simulation, **kwargs)
..\idmtools_platform_slurm\platform_operations\simulation_operations.py:61: in platform_create
    self.platform._assets.link_common_assets(simulation)
..\idmtools_platform_slurm\platform_operations\asset_collection_operations.py:68: in link_common_assets
    self.platform._op_client.link_dir(common_asset_dir, link_dir)
..\idmtools_platform_slurm\slurm_operations.py:243: in link_dir
    link.symlink_to(target)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = WindowsPath('C:/Users/sharonch/github/idmtools/idmtools_platform_slurm/tests/DEST/Suite000000/Experiment000000/Simulation000500/Assets')
target = WindowsPath('C:/Users/sharonch/github/idmtools/idmtools_platform_slurm/tests/DEST/Suite000000/Experiment000000/Assets')
target_is_directory = False

    def symlink_to(self, target, target_is_directory=False):
        """
        Make this path a symlink pointing to the target path.
        Note the order of arguments (link, target) is the reverse of os.symlink.
        """
>       self._accessor.symlink(target, self, target_is_directory)
E       FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\Users\\sharonch\\github\\idmtools\\idmtools_platform_slurm\\tests\\DEST\\Suite000000\\Experiment000000\\Assets' -> 'C:\\Users\\sharonch\\github\\idmtools\\idmtools_platform_slurm\\tests\\DEST\\Suite000000\\Experiment000000\\Simulation000500\\Assets'

c:\python39\lib\pathlib.py:1393: FileExistsError

get run_sumulation.sh error if run again without clear job_directory

self = WindowsPath('C:/Users/sharonch/github/idmtools/idmtools_platform_slurm/tests/DEST/Suite000000/Experiment000000/run_simulation.sh')
target = WindowsPath('C:/Users/sharonch/github/idmtools/idmtools_platform_slurm/idmtools_platform_slurm/assets/run_simulation.sh')
target_is_directory = False

    def symlink_to(self, target, target_is_directory=False):
        """
        Make this path a symlink pointing to the target path.
        Note the order of arguments (link, target) is the reverse of os.symlink.
        """
>       self._accessor.symlink(target, self, target_is_directory)
E       FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\Users\\sharonch\\github\\idmtools\\idmtools_platform_slurm\\idmtools_platform_slurm\\assets\\run_simulation.sh' -> 'C:\\Users\\sharonch\\github\\idmtools\\idmtools_platform_slurm\\tests\\DEST\\Suite000000\\Experiment000000\\run_simulation.sh'

c:\python39\lib\pathlib.py:1393: FileExistsError

idmtools_core/tests/test_item_sequence.py

shchen-idmod · 2022-09-07T07:10:18Z

idmtools_1.ini

[COMMON]
id_generator = item_sequence

[MTest]
type = Slurm

[item_sequence]
sequence_file = item_sequences.json
id_format_str = {item_name}{data[item_name]:06d}

Run following code by delete DEST folder first, always get this error:

Commissioning Simulations:   0%|          | 0/500 [00:00<?, ?simulation/s]            
test_1.py:45 (TestItemSequence.test_1)
self = <tests.test_1.TestItemSequence testMethod=test_1>

    @pytest.mark.serial
    @pytest.mark.performance
    def test_1(self):
        clear_id_cache()
        parser = IdmConfigParser()
        parser._load_config_file(file_name='idmtools_1.ini')
        sequence_file = self.get_sequence_file()
        platform = Platform('MTest', missing_ok=True, job_directory="DEST")
        task = JSONConfiguredPythonTask(script_path=os.path.join(COMMON_INPUT_PATH, "python", "model1.py"),
                                        envelope="parameters", parameters=(dict(c=0)))
        ts = TemplatedSimulations(base_task=task)
        e = Experiment.from_template(ts)
        from idmtools.builders import SimulationBuilder
        builder = SimulationBuilder()
    
        def param_update(simulation, param, value):
            return simulation.task.set_parameter(param, value)
    
        builder.add_sweep_definition(partial(param_update, param="a"), range(10 * get_performance_scale()))
        builder.add_sweep_definition(partial(param_update, param="b"), range(50))
        e.simulations.add_builder(builder)
        add_dummy_suite(e)
>       e.run(platform=platform, wait_until_done=False, dry_run=True)

test_1.py:68: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\..\idmtools_core\idmtools\entities\experiment.py:544: in run
    p.run_items(self, **run_opts)
..\..\idmtools_core\idmtools\entities\iplatform.py:507: in run_items
    getattr(self, interface).run_item(item, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:260: in run_item
    self.pre_run_item(experiment, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_experiment_operations.py:225: in pre_run_item
    experiment.simulations = self.platform._create_items_of_type(experiment.simulations, ItemType.SIMULATION, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform.py:469: in _create_items_of_type
    ni = getattr(self, interface).batch_create(items, **kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:134: in batch_create
    return batch_create_items(sims, create_func=self.create, display_progress=display_progress,
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:151: in batch_create_items
    results = show_progress_of_batch(prog, futures)
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:172: in show_progress_of_batch
    result = future.result()
c:\python39\lib\concurrent\futures\_base.py:438: in result
    return self.__get_result()
c:\python39\lib\concurrent\futures\_base.py:390: in __get_result
    raise self._exception
c:\python39\lib\concurrent\futures\thread.py:52: in run
    result = self.fn(*self.args, **self.kwargs)
..\..\idmtools_core\idmtools\entities\iplatform_ops\utils.py:61: in item_batch_worker_thread
    ret.append(create_func(item, **kwargs))
..\..\idmtools_core\idmtools\entities\iplatform_ops\iplatform_simulation_operations.py:99: in create
    simulation._platform_object = self.platform_create(simulation, **kwargs)
..\idmtools_platform_slurm\platform_operations\simulation_operations.py:59: in platform_create
    self.platform._op_client.mk_directory(simulation)
..\idmtools_platform_slurm\slurm_operations.py:214: in mk_directory
    target = self.get_directory(item)
..\idmtools_platform_slurm\slurm_operations.py:171: in get_directory
    item_dir = Path(exp_dir, item.id)
..\..\idmtools_core\idmtools\core\interfaces\iitem.py:97: in id
    if self.uid:
..\..\idmtools_core\idmtools\core\interfaces\iitem.py:65: in uid
    self._uid = plugin.idmtools_generate_id(self)
..\..\idmtools_core\idmtools\plugins\item_sequence.py:72: in idmtools_generate_id
    data = load_existing_sequence_data(sequence_file)
..\..\idmtools_core\idmtools\plugins\item_sequence.py:41: in load_existing_sequence_data
    data = json.load(file)
c:\python39\lib\json\__init__.py:293: in load
    return loads(fp.read(),
c:\python39\lib\json\__init__.py:346: in loads
    return _default_decoder.decode(s)
c:\python39\lib\json\decoder.py:337: in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <json.decoder.JSONDecoder object at 0x000001EE071105B0>, s = '', idx = 0

    def raw_decode(self, s, idx=0):
        """Decode a JSON document from ``s`` (a ``str`` beginning with
        a JSON document) and return a 2-tuple of the Python
        representation and the index in ``s`` where the document ended.
    
        This can be used to decode a JSON document from a string that may
        have extraneous data at the end.
    
        """
        try:
            obj, end = self.scan_once(s, idx)
        except StopIteration as err:
>           raise JSONDecodeError("Expecting value", s, err.value) from None
E           json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

c:\python39\lib\json\decoder.py:355: JSONDecodeError

…nnecessarily

…irectory_map.py to avoid confusion

…ling/idmtools into 1810-fix

…on metadata in file. & linting fixes

idmtools_core/tests/test_item_sequence.py

…platform

shchen-idmod · 2022-12-15T22:14:13Z

idmtools_test/idmtools_test/utils/execute_operations/experiment_operations.py

@@ -231,3 +234,9 @@ def post_run_item(self, experiment: Experiment, **kwargs):
        sim_path = Path(exp_path, "simulation_index.json")
        with open(sim_path, "w") as f:
            json.dump([s.id for s in experiment.simulations], f)
+
+        if IdmConfigParser.get_option(None, "id_generator", "uuid").lower() == "item_sequence":


This is the almost exactly what super class function of post_run_item does (still missing experiment.post_run(self.platform). so no need to copy code. just need call super function.

shchen-idmod · 2022-12-15T22:27:15Z

idmtools/idmtools_platform_comps/idmtools_platform_comps/comps_operations/experiment_operations.py

Line 44 in e3ec545

    
           def get(self, experiment_id: UUID, columns: Optional[List[str]] = None, load_children: Optional[List[str]] = None,

idmtools/idmtools_platform_comps/idmtools_platform_comps/comps_operations/simulation_operations.py

Line 114 in e3ec545

    
           def get(self, simulation_id: UUID, columns: Optional[List[str]] = None, load_children: Optional[List[str]] = None,

idmtools/idmtools_platform_comps/idmtools_platform_comps/comps_operations/suite_operations.py

Line 29 in e3ec545

    
           def get(self, suite_id: UUID, columns: Optional[List[str]] = None, load_children: Optional[List[str]] = None,

idmtools/idmtools_platform_comps/idmtools_platform_comps/comps_operations/workflow_item_operations.py

Line 35 in e3ec545

    
           def get(self, workflow_item_id: UUID, columns: Optional[List[str]] = None, load_children: Optional[List[str]] = None,

idmtools/idmtools_platform_comps/idmtools_platform_comps/comps_operations/asset_collection_operations.py

Line 35 in e3ec545

    
           def get(self, asset_collection_id: Optional[UUID], load_children: Optional[List[str]] = None, query_criteria: Optional[QueryCriteria] = None, **kwargs) -> COMPSAssetCollection:

You still have lot of places using UUID for id as above lines. Do you intend to do that?

idmtools_test/idmtools_test/utils/execute_operations/experiment_operations.py

shchen-idmod

Tested the latest fixes. Even there are still few issues(like can not random print id, too fridge if let user define sequence file), but overall feature is good.

Maybe we should consider to release to a separate branch instead of dev branch until we are sure to release this feature. Meanwhile we can keep develop on dev branch and release new stuff

shchen-idmod · 2023-02-06T20:19:25Z

Can we fix conflicts? @emilykclaps

emilydriano · 2023-02-09T22:58:40Z

@shchen-idmod just resolved conflicts. Where are we with this PR? Can we merge to dev, or did you want to release to separate branch until ready to merge? Thx!

Add beta feature warning

shchen-idmod · 2023-02-10T00:02:02Z

FAILED test_slurm_cancel1.py::TestSlurmCanceling::test_canceling_a_full_experiment - NameError: name 'meta' is not defined
FAILED test_slurm_cancel1.py::TestSlurmCanceling::test_canceling_a_full_suite - NameError: name 'meta' is not defined
FAILED test_slurm_cancel1.py::TestSlurmCanceling::test_canceling_a_single_simulation - NameError: name 'meta' is not defined
You may missing something from latest code.

… operations

# Conflicts: # idmtools_platform_slurm/idmtools_platform_slurm/platform_operations/experiment_operations.py

shchen-idmod · 2023-02-21T23:26:00Z

There is known issue about build-docs. Other than that everything looks good

devclinton and others added 2 commits August 25, 2022 10:42

Better logging

c6aba65

Added back changes made to 1810 original branch

42d3893

emilydriano added the Core label Aug 25, 2022

emilydriano requested review from devclinton and shchen-idmod August 25, 2022 19:47

shchen-idmod requested changes Aug 29, 2022

View reviewed changes

idmtools_core/tests/test_item_sequence.py Outdated Show resolved Hide resolved

shchen-idmod requested changes Aug 29, 2022

View reviewed changes

idmtools_core/tests/test_item_sequence.py Outdated Show resolved Hide resolved

devclinton and others added 12 commits August 30, 2022 11:29

Make test platform compatible with id generators

b9745a9

updated platform in test_item_sequence to 'Test' and added tests base…

a1ae14c

…d on Sharon's feedback

* Fix name of dummy suite method

0908d9d

* Ensure slurm uses uuid

Merge remote-tracking branch 'origin/1810-fix' into 1810-fix

ea96c12

* Add configuration caching to item sequence

d2925c5

* add configuration caching for id generation * add performance test scaler

Add cache clearing to tests

33b50ef

Fix tests

073df66

Update slurm tests to be UUID agnostic

e3ac2b6

Make test valid

cee87fd

Mark test serial to prevent being ran with other tests because of con…

c0f6eed

…fig contraints

Rest id on close

6b8ee82

Updated documentation for item_sequence plugin, cleaned up test_item_…

269f789

…sequence code.

emilydriano requested a review from ZDu-IDM September 2, 2022 22:48

emilydriano added 2 commits September 6, 2022 11:08

Added methods to clear configuration before persistence_services and …

c12b778

…platform_analysis tests

Added documentation for new functions related to id generation.

ce414fa

devclinton approved these changes Sep 6, 2022

View reviewed changes

shchen-idmod requested changes Sep 7, 2022

View reviewed changes

idmtools_core/tests/test_item_sequence.py Show resolved Hide resolved

devclinton added 2 commits September 7, 2022 09:40

Change order to ensure file is locked during write

7d42595

Add file locking

05b6b6d

emilydriano and others added 8 commits December 12, 2022 10:58

modified experiment result to avoid causing the sims to be iterated u…

71f732a

…nnecessarily

modified tests to exclude slurm experiment simulation data

d338808

modified create_sim_dir_map test to account for metadata change

1e90f8b

Merge branch 'dev' into 1810-fix

600f084

changed named 'slurm_experiment' to 'experiment' in test_create_sim_d…

5fdc8b0

…irectory_map.py to avoid confusion

Merge branch '1810-fix' of https://github.com/InstituteforDiseaseMode…

56f26d7

…ling/idmtools into 1810-fix

used experiment post create in test execute platform to save simulati…

a3899a3

…on metadata in file. & linting fixes

included missing package

6b89439

shchen-idmod requested changes Dec 15, 2022

View reviewed changes

idmtools_core/tests/test_item_sequence.py Show resolved Hide resolved

emilydriano and others added 2 commits December 15, 2022 12:06

added backup sequence file process to post-run hook for test-execute …

8e81982

…platform

Merge branch 'dev' into 1810-fix

e3ec545

shchen-idmod requested changes Dec 15, 2022

View reviewed changes

simplified code with super function

965a7e6

ZDu-IDM requested changes Dec 16, 2022

View reviewed changes

idmtools_test/idmtools_test/utils/execute_operations/experiment_operations.py Outdated Show resolved Hide resolved

added kwargs to post_run_item call

ea7ba8c

shchen-idmod self-requested a review January 10, 2023 19:12

shchen-idmod approved these changes Jan 10, 2023

View reviewed changes

ZDu-IDM approved these changes Jan 10, 2023

View reviewed changes

Merge branch 'dev' into 1810-fix

99463d3

devclinton and others added 2 commits February 9, 2023 15:25

Update item_sequence.py

14e6c2f

Add beta feature warning

Update item_sequence.py

6b9a9aa

emilydriano added 2 commits February 16, 2023 11:41

added changes defining 'meta' var in idmtools_platform_slurm platform…

32ffb5f

… operations

Merge remote-tracking branch 'origin/1810-fix' into 1810-fix

557b1fe

# Conflicts: # idmtools_platform_slurm/idmtools_platform_slurm/platform_operations/experiment_operations.py

shchen-idmod merged commit 95e6c97 into dev Feb 21, 2023

shchen-idmod deleted the 1810-fix branch February 1, 2024 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1810 fix #1825

1810 fix #1825

emilydriano commented Aug 25, 2022 •

edited by devclinton

shchen-idmod commented Aug 29, 2022 •

edited

shchen-idmod commented Aug 30, 2022 •

edited

shchen-idmod commented Sep 7, 2022 •

edited

shchen-idmod commented Sep 7, 2022

shchen-idmod Dec 15, 2022 •

edited

shchen-idmod commented Dec 15, 2022

shchen-idmod left a comment •

edited

shchen-idmod commented Feb 6, 2023 •

edited

emilydriano commented Feb 9, 2023

shchen-idmod commented Feb 10, 2023

shchen-idmod commented Feb 21, 2023

1810 fix #1825

1810 fix #1825

Conversation

emilydriano commented Aug 25, 2022 • edited by devclinton

shchen-idmod commented Aug 29, 2022 • edited

shchen-idmod commented Aug 30, 2022 • edited

shchen-idmod commented Sep 7, 2022 • edited

shchen-idmod commented Sep 7, 2022

shchen-idmod Dec 15, 2022 • edited

Choose a reason for hiding this comment

shchen-idmod commented Dec 15, 2022

shchen-idmod left a comment • edited

Choose a reason for hiding this comment

shchen-idmod commented Feb 6, 2023 • edited

emilydriano commented Feb 9, 2023

shchen-idmod commented Feb 10, 2023

shchen-idmod commented Feb 21, 2023

emilydriano commented Aug 25, 2022 •

edited by devclinton

shchen-idmod commented Aug 29, 2022 •

edited

shchen-idmod commented Aug 30, 2022 •

edited

shchen-idmod commented Sep 7, 2022 •

edited

shchen-idmod Dec 15, 2022 •

edited

shchen-idmod left a comment •

edited

shchen-idmod commented Feb 6, 2023 •

edited