Add viewmodel get key to koin, and add KoinViewModelLazy class #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allen-hsu
changed the title
arnaudgiuliani
added
the
status:checking
|
The VIewModel API has been revamped with latest lifecycle library in 2.5.1. Key property can be accessed in generic API. Thanks for your proposal. Don't hesitate to give feedback on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, because the ViewModel provider has the function (
ViewModelProvider.get(key, clazz)) that can let you pass the key to ViewModel provide in order to get a different ViewModel with a different key, I want to raise this PR, and according to this :#213
Originally I was going to change
ViewModelProvider.resolveInstance, but I found that the new version of koin uses ViewModelLazy instead, but it is an Android lib, so I tried to build a KoinViewModelLazy, please consider this scenario carefully, I believe that I am not the only one who needs to pass in the key