[dont merge] feat: offchain vault instantiate/subscribe/redeem examples #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinhphuctadang
changed the title
nicolasbaum
reviewed
Sep 12, 2023
|
yes, fully permissionless on testnet |
aarmoa
requested changes
Nov 7, 2023
There was a problem hiding this comment.
I have added some comments in the examples.
Besides the comments, I think we should be pointing this PR to the dev branch, since we are going to release soon a new version compatible with chain 1.12. Merging this into master would force us to sync again master into dev
|
|
||
| func main() { | ||
| // network := common.LoadNetwork("mainnet", "k8s") | ||
| network := common.LoadNetwork("testnet", "k8s") |
There was a problem hiding this comment.
k8s should no longer be used
Comment on lines
+57
to
+62
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network.ChainGrpcEndpoint, | ||
| common.OptionTLSCert(network.ChainTlsCert), | ||
| common.OptionGasPrices("500000000inj"), | ||
| ) |
There was a problem hiding this comment.
NewChainClient now should receive the network instance instead of only the endpoint. And the certs are taken from the network directly inside the ChainClient.
Suggested change
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network.ChainGrpcEndpoint, | |
| common.OptionTLSCert(network.ChainTlsCert), | |
| common.OptionGasPrices("500000000inj"), | |
| ) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices("500000000inj"), | |
| ) |
|
|
||
| func main() { | ||
| // network := common.LoadNetwork("mainnet", "k8s") | ||
| network := common.LoadNetwork("testnet", "k8s") |
Comment on lines
+56
to
+62
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmRPC) | ||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network.ChainGrpcEndpoint, | ||
| common.OptionTLSCert(network.ChainTlsCert), | ||
| common.OptionGasPrices("500000000inj"), | ||
| ) |
There was a problem hiding this comment.
Same comment here
Suggested change
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmRPC) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network.ChainGrpcEndpoint, | |
| common.OptionTLSCert(network.ChainTlsCert), | |
| common.OptionGasPrices("500000000inj"), | |
| ) | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmRPC) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices("500000000inj"), | |
| ) |
Comment on lines
+47
to
+48
| // network := common.LoadNetwork("mainnet", "k8s") | ||
| network := common.LoadNetwork("testnet", "k8s") |
Comment on lines
+57
to
+62
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network.ChainGrpcEndpoint, | ||
| common.OptionTLSCert(network.ChainTlsCert), | ||
| common.OptionGasPrices("500000000inj"), | ||
| ) |
There was a problem hiding this comment.
Same comment here
Suggested change
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network.ChainGrpcEndpoint, | |
| common.OptionTLSCert(network.ChainTlsCert), | |
| common.OptionGasPrices("500000000inj"), | |
| ) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices("500000000inj"), | |
| ) |
Comment on lines
+26
to
+27
| // network := common.LoadNetwork("mainnet", "k8s") | ||
| network := common.LoadNetwork("testnet", "k8s") |
Comment on lines
+57
to
+62
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network.ChainGrpcEndpoint, | ||
| common.OptionTLSCert(network.ChainTlsCert), | ||
| common.OptionGasPrices("500000000inj"), | ||
| ) |
There was a problem hiding this comment.
Same comment here
Suggested change
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network.ChainGrpcEndpoint, | |
| common.OptionTLSCert(network.ChainTlsCert), | |
| common.OptionGasPrices("500000000inj"), | |
| ) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices("500000000inj"), | |
| ) |
Comment on lines
+47
to
+48
| // network := common.LoadNetwork("mainnet", "k8s") | ||
| network := common.LoadNetwork("testnet", "k8s") |
Comment on lines
+82
to
+87
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network.ChainGrpcEndpoint, | ||
| common.OptionTLSCert(network.ChainTlsCert), | ||
| common.OptionGasPrices("500000000inj"), | ||
| ) |
There was a problem hiding this comment.
Same comment here
Suggested change
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network.ChainGrpcEndpoint, | |
| common.OptionTLSCert(network.ChainTlsCert), | |
| common.OptionGasPrices("500000000inj"), | |
| ) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices("500000000inj"), | |
| ) |
vinhphuctadang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test create vaults and other subscribe/redeem too
