Add setting to throw exception in non-interactive mode if some params are missing #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stof any chance that this PR would be reviewed? |
fduch
force-pushed
the
exception-if-missing
branch
2 times, most recently
from
9122b11
to
d662982
Compare
fduch
added a commit
to fduch/ParameterHandler
that referenced
this pull request
Sep 19, 2014
* exception-if-missing: add setting to throw exception in non-interactive mode if some params are missing
|
+1 for such a functionality |
|
@ZeeCoder since @stof didn't give any feedback to this PR i use exception-if-missing branch in my fork of the official repository without any issues for almost a year.. :) |
|
+1 , but:
Manage fine without this making sure params have sensible defaults. |
|
+1 Merging this PR would solve a lot of issues we have with our continuous integration. |
|
👍 |
|
@stof Can we help you reviewing this PR? It'd be indeed really helpful. Thanks. |
fduch
force-pushed
the
exception-if-missing
branch
2 times, most recently
from
debbb26
to
d662982
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers #63 and provides new
exception-if-missingconfiguration option.By default the behavior of script handler is the same as current. But when
exception-if-missingoption is set totrueParameterHandler will throw an exception when some parameters are missing. This is very useful during build/deploy process (executed for example on build/ci servers) when it is needed only to validateparameters.ymlfile before installing the application and abort the process when something went wrong, but not to change it's original content in any way.This behavior affects only non-interactive mode.