Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested parameters #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lucascourot
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #46, #36, #35
License MIT
Test repo https://github.com/lucascourot/test-multi-level-params

This PR provides a support for nested parameters. You can check out the demo to play with it.

}

public function processFile(array $config)
{
$config = $this->processConfig($config);

$realFile = $config['file'];
$realFile = $config['file'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't align the = signs. I don't follow this rule in my projects as I find it is a bad one. It forces to introduces useless git conflicts risks each time we add a longer variable name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@rgazelot
Copy link
Contributor

What is the status of this PR ? I think this will be useful for many people.

@lucascourot
Copy link
Contributor Author

@rgazelot it's not going to be merged IMO

@litzinger
Copy link

Can you explain why this will not be merged? Is there another way to use arrays as parameter values?

@hlecorche
Copy link

No news ?

@Gregoire-M
Copy link

+1

@TomasVotruba
Copy link

Just came across the same issue. Any suggestions?

cc @vitek-rostislav

@lexdevelop
Copy link

lexdevelop commented Nov 26, 2019

@stof What's the status with this PR, this is really useful.
At least we can add parameter-key to support a child element like:
parameter-key: "parameters/some-settings"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants