[#133] reflect tabs in url #135
Conversation
previously it defaulted to "topContributors" whether or not any contributions had been made if you navigate to a project from the site everything works as intended, but if you paste the url to a project you own into the browser it defaults to the "register a donation" rather the "incoming donations" tab (previously it was defaulting to the "top contributors" tab)
workflow run keeps failing; seems like it may be bc the prettier versions weren't the same
ok this should work, finally :')
project tabs now appear in URL when clicked (but using that URL doesn't yet set the page to the correct tabs) QUESTION Should value be set to a more specific type here?: const handleTabChange = (type: 'tab' | 'comments', value: string | null)
url generated by changing tabs can now be pasted into the browser and will maintain the relevant tabs
| string | null | ||
| >(null) | ||
|
|
||
| // QUESTION: should value be set to a more specific type? |
There was a problem hiding this comment.
Perhaps, but it also works like this. 😊 I imagine the next step could be to move this logic into a wrapper around the taps component so that it becomes available on all pages that use tabs, but that can wait until we have more usage on the platform and people use the feature. I'll find it very convenient to be able to just link people to their preferences tab when they ask where they can adjust their preferences! 😃
There was a problem hiding this comment.
ooh ok yeah! maybe this would be good for me to do before setting this up for the project page filters
There was a problem hiding this comment.
Potentially! But let's hold off on it until we have more of a direction again. Matt wants to do some interviews to see what else we can help with, so I'm not currently confident enough that it'll be worth your while.
|
Great work! And sorry that took me so long to review. (Remember to enter your hours on Deel. :-3) |
within an individual project, the URL now upates according to which tab/s you've selected, you can navigate back and forth in the browser to move between tabs, and you can navigate to a project with specific tabs selected using the relevant URL