Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

creates rollout restart route for grader setup service #645

Open
wants to merge 47 commits into
base: main
Choose a base branch
from

Conversation

Abhi94N
Copy link

@Abhi94N Abhi94N commented Mar 25, 2022

  1. Command to restart deployment
    wget --method POST http://grader-setup-service.coffee.svc.cluster.local:8000/services/coffee/get-another-test/restart -O output.txt
  2. Response for successful grader is
    {"message":"grader-get-another-test successfully deployed to organization coffee","success":true}
    with status 200
  3. Response if grader fails ERROR 404: NOT FOUND.
  4. Deployment has been tested with wget in namespace coffee after remoting into a grader image

Question: should I also include the ability to add services to services dict in restart call?

@Abhi94N Abhi94N added feature New feature or request enhancement labels Mar 25, 2022
@Abhi94N Abhi94N self-assigned this Mar 25, 2022
@Abhi94N Abhi94N requested a review from jgwerner March 25, 2022 22:05
@ghost
Copy link

ghost commented Mar 25, 2022

CodeSee Review Map:

Review these changes using an interactive CodeSee Map

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

@jgwerner
Copy link
Member

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Copy link
Member

@jgwerner jgwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We identified new issues on unchanged lines of code. Navigate to the Amazon CodeGuru Reviewer console to view the recommendations to fix them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants