Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions workflow to run tests #584

Merged
merged 5 commits into from Nov 19, 2022
Merged

Add GitHub actions workflow to run tests #584

merged 5 commits into from Nov 19, 2022

Conversation

Mairu
Copy link
Member

@Mairu Mairu commented Nov 6, 2022

Description

Add a CI GitHub Actions workflow to run tests on pushes and pull requests.

Tests would fail on PHP 8.1 at the moment.

@blackcoder87
Copy link
Contributor

I noticed these warnings:

Node.js 12 actions are deprecated.
The save-state command is deprecated and will be disabled soon.
The set-output command is deprecated and will be disabled soon.

Is it possible to update the actions as described here or would that break the unit tests?
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

@Mairu
Copy link
Member Author

Mairu commented Nov 19, 2022

The save-state issue should be fixed upstream -> shivammathur/setup-php#654

For the Node.js warning, I have not found it in the logs and as we do not actively use it, I guess it will also be fixed upstream. I will update the old action versions.

From my point of view, this is ready to be merged. Ok, the changes in master break the builds.

Any adjustments like PHP or MySQL versions could be adjusted later.

@Mairu
Copy link
Member Author

Mairu commented Nov 19, 2022

Well the php unit version question should be answered, and for sure the version from the vendor folder has to be used. So if you change the tests for whatever PHPUnit version, you have to adjust the version in the composer.json file. @hhunderter

@blackcoder87
Copy link
Contributor

So my fix for the unit test should be merged and then this pull request. After that the unit tests should be fine for PHP 7.4 and PHP 8.0 with PHPUnit 5.7.27.
Later the tests should be run for PHP 7.0 - PHP 8.1 as long as Ilch supports the older versions of PHP.

See this comment:
#588 (comment)

@Mairu Mairu merged commit 400c49e into master Nov 19, 2022
@Mairu Mairu deleted the github-actions branch November 19, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants