Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Enh/storage s3 timeout #5301

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 5, 2024

What do these changes do?

  • Handles timeout
  • Creates a single instance of paginator
  • Overcall cleanup of files while analysing the code

Related issue/s

  • Problem experienced while copying taylor's large template

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.4%. Comparing base (cafbf96) to head (825415b).
Report is 32 commits behind head on master.

❗ Current head 825415b differs from pull request most recent head e8f595d. Consider uploading reports for the commit e8f595d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5301      +/-   ##
=========================================
+ Coverage    84.5%   86.4%    +1.8%     
=========================================
  Files          10    1284    +1274     
  Lines         214   52198   +51984     
  Branches       25    1172    +1147     
=========================================
+ Hits          181   45140   +44959     
- Misses         23    6815    +6792     
- Partials       10     243     +233     
Flag Coverage Δ
integrationtests 62.5% <ø> (?)
unittests 84.9% <ø> (+0.3%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1294 files with indirect coverage changes

@pcrespov pcrespov force-pushed the enh/storage-s3-timeout branch 2 times, most recently from 900f1bd to d359d36 Compare February 12, 2024 14:27
@pcrespov pcrespov added this to the Schoggilebe milestone Feb 13, 2024
@pcrespov pcrespov added a:storage issue related to storage service t:maintenance Some planned maintenance work labels Feb 13, 2024
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@elisabettai
Copy link
Contributor

@pcrespov, I've added a bug report related to this. I'll see if I find more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants