Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Is4481/pydantic migration #5275

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jan 28, 2024

What do these changes do?

TIP: SEE https://github.com/tiangolo/fastapi/blob/master/fastapi/_compat.py approach. Do not keep backwards compatibility but we can keep some of the adapters

  • aws-library
  • dask-task-models-library
  • models-library
  • pytest-simcore?
  • service-integration
  • service-library
  • settings-library
  • simcore-sdk

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@pcrespov pcrespov changed the title Is4481/pydantic migration WIP: Is4481/pydantic migration Jan 28, 2024
Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

80 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3693767) 87.2% compared to head (78f5b0e) 55.4%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5275      +/-   ##
=========================================
- Coverage    87.2%   55.4%   -31.9%     
=========================================
  Files        1307      54    -1253     
  Lines       53522    2583   -50939     
  Branches     1170       0    -1170     
=========================================
- Hits        46724    1431   -45293     
+ Misses       6549    1152    -5397     
+ Partials      249       0     -249     
Flag Coverage Δ
integrationtests ?
unittests 55.4% <ø> (-29.8%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1256 files with indirect coverage changes

@pcrespov pcrespov self-assigned this Jan 28, 2024
@pcrespov pcrespov added t:maintenance Some planned maintenance work a:models-library labels Jan 28, 2024
@pcrespov pcrespov added this to the Schoggilebe milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:models-library t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major upgrade to pydantic 2.0
1 participant