-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Is4481/pydantic migration #5275
Draft
pcrespov
wants to merge
9
commits into
ITISFoundation:master
Choose a base branch
from
pcrespov:is4481/pydantic-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Is4481/pydantic migration #5275
pcrespov
wants to merge
9
commits into
ITISFoundation:master
from
pcrespov:is4481/pydantic-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 80 New issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5275 +/- ##
=========================================
- Coverage 87.2% 55.4% -31.9%
=========================================
Files 1307 54 -1253
Lines 53522 2583 -50939
Branches 1170 0 -1170
=========================================
- Hits 46724 1431 -45293
+ Misses 6549 1152 -5397
+ Partials 249 0 -249
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
TIP: SEE https://github.com/tiangolo/fastapi/blob/master/fastapi/_compat.py approach. Do not keep backwards compatibility but we can keep some of the adapters
Related issue/s
How to test
Dev Checklist
DevOps Checklist