Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix templates publish/open with states as directories #4586

Merged
merged 11 commits into from
Aug 8, 2023

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Aug 7, 2023

What do these changes do?

Templates were broken since the states of the folders are treated as folders.

  • 🐛 storage knows how to copy s3_paths that can be directories

Related issue/s

How to test

DevOps Checklist

@GitHK GitHK self-assigned this Aug 7, 2023
@GitHK GitHK added a:storage issue related to storage service a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Aug 7, 2023
@GitHK GitHK added this to the Sundae milestone Aug 7, 2023
@GitHK GitHK marked this pull request as ready for review August 7, 2023 13:51
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the _get_size function and the datetime format. not sure this will not trigger an issue.

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #4586 (a0eb8ab) into master (e4b0789) will decrease coverage by 9.2%.
The diff coverage is 87.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4586     +/-   ##
========================================
- Coverage    76.2%   67.1%   -9.2%     
========================================
  Files         562     484     -78     
  Lines       27975   25294   -2681     
  Branches      533     188    -345     
========================================
- Hits        21332   16980   -4352     
- Misses       6519    8267   +1748     
+ Partials      124      47     -77     
Flag Coverage Δ
integrationtests 65.2% <ø> (-1.5%) ⬇️
unittests 90.7% <87.5%> (+16.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rage/src/simcore_service_storage/simcore_s3_dsm.py 94.6% <82.6%> (-1.0%) ⬇️
.../src/simcore_service_storage/handlers_locations.py 96.0% <100.0%> (ø)
...s/storage/src/simcore_service_storage/s3_client.py 98.7% <100.0%> (+<0.1%) ⬆️

... and 215 files with indirect coverage changes

@GitHK GitHK requested a review from sanderegg August 7, 2023 14:50
@GitHK GitHK mentioned this pull request Aug 8, 2023
26 tasks
@codeclimate
Copy link

codeclimate bot commented Aug 8, 2023

Code Climate has analyzed commit a0eb8ab and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thanks. I am not sure I understand why you create test_simcore_s3_dsm.py while there is already a test_handlers_simcore_s3.py. But whatever, very cool! thanks!

@GitHK GitHK enabled auto-merge (squash) August 8, 2023 06:12
@GitHK GitHK merged commit cf376e0 into ITISFoundation:master Aug 8, 2023
52 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 22, 2023
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants