🐛 rclone preserves symlinks even if broken

[GitHK]

What do these changes do?

Unfortunately rclone was configured to copy the content pointed by the symlink. This caused rclone to fail if the symlink was broken (the pointed file did not exists).

• ✨ adds regression test
• 🐛 rclone copies symlinks as they are without following them

Related issue/s

• M1-12 Maintenance and DevOps osparc-issues#675
• allows master to be published 🚀 Release v1.58.0 #4574

How to test

DevOps Checklist

[codeclimate]

Code Climate has analyzed commit 7cf8d26 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.1% Duplication

[codecov]

Codecov Report

Merging #4585 (7cf8d26) into master (b6ef630) will increase coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4585     +/-   ##
========================================
+ Coverage    86.7%   86.8%   +0.1%     
========================================
  Files        1023     744    -279     
  Lines       43772   34047   -9725     
  Branches     1013     188    -825     
========================================
- Hits        37967   29581   -8386     
+ Misses       5578    4420   -1158     
+ Partials      227      46    -181     

Flag	Coverage Δ
integrationtests	65.2% <ø> (-1.5%)	⬇️
unittests	83.9% <ø> (-0.4%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py	97.8% <ø> (ø)

... and 288 files with indirect coverage changes

[elisabettai]

Thanks for the quick fix!

[GitHK]

Thanks for the quick fix!

I will shutdown the node as soon as this gets in master. TO check that nothing else is broken.

[GitHK]

Thanks for the quick fix!

I will shutdown the node as soon as this gets in master. TO check that nothing else is broken.

Allo good, this fixed the issue!