♻️ Maintenance: cleanup catalog

[sanderegg]

What do these changes do?

• De-duplicate models.
• /{service_key}/{service_version}/resources now checks again that the service passed really uses the correct expected names and versions like all other API entrypoints of the catalog service (@elisabettai this should help with your issue this morning as well)
• remove caching in catalog of /resources entrypoint as this prevents changing the DB and having immediate response for no clear gain

Related issue/s

• sub part of ✨ Personalized resources: Allow override of computational service needed resources (⚠️ devops) #3989
• fixes M1-12 Maintenance and DevOps osparc-issues#675
• fixes personalizable resource limits osparc-issues#618

How to test

Checklist

[codecov]

Codecov Report

Merging #3983 (f760f1d) into master (b2a526e) will decrease coverage by 0.4%.
The diff coverage is 75.8%.

@@           Coverage Diff            @@
##           master   #3983     +/-   ##
========================================
- Coverage    86.1%   85.8%   -0.4%     
========================================
  Files         765     828     +63     
  Lines       34884   37194   +2310     
  Branches      848     487    -361     
========================================
+ Hits        30051   31919   +1868     
- Misses       4609    5147    +538     
+ Partials      224     128     -96     

Flag	Coverage Δ
integrationtests	66.7% <ø> (+13.9%)	⬆️
unittests	82.3% <75.8%> (-1.9%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/models-library/src/models_library/basic_regex.py	100.0% <ø> (ø)
...imcore_service_catalog/db/repositories/products.py	71.4% <0.0%> (ø)
...catalog/src/simcore_service_catalog/utils/pools.py	0.0% <0.0%> (ø)
.../simcore_service_catalog/db/repositories/groups.py	59.4% <42.8%> (ø)
...rc/simcore_service_catalog/db/repositories/dags.py	45.9% <45.4%> (ø)
...c/simcore_service_catalog/core/background_tasks.py	59.1% <50.0%> (ø)
...imcore_service_catalog/db/repositories/services.py	74.3% <61.9%> (ø)
...log/src/simcore_service_catalog/api/routes/dags.py	62.7% <66.6%> (ø)
.../simcore_service_catalog/services/access_rights.py	85.1% <80.0%> (ø)
...e_service_catalog/api/routes/services_resources.py	86.6% <88.8%> (ø)
... and 18 more

... and 303 files with indirect coverage changes

[elisabettai]

Thanks! You were too fast, I haven't had time to create an issue yet. 😉

[GitHK]

👍
Question: are dynamic-services happy about these changes? Did you get to test with s4l and other muli container services?

[pcrespov]

Thx for the cleanup!

[pcrespov]

Thx for the cleanup!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit f760f1d and detected 0 issues on this pull request.

View more on Code Climate.