Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 test_port_key_sequential_event_generation is still flaky #3693

Closed

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 16, 2022

What do these changes do?

Just marking to retry, CI fails. Create issue to track #3694

Related issue/s

How to test

Checklist

@GitHK GitHK marked this pull request as ready for review December 16, 2022 07:48
@GitHK GitHK self-assigned this Dec 16, 2022
@GitHK GitHK added the a:dynamic-sidecar dynamic-sidecar service label Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #3693 (f9811cc) into master (7ccadab) will decrease coverage by 4.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3693      +/-   ##
=========================================
- Coverage    84.4%   80.3%    -4.2%     
=========================================
  Files         883     167     -716     
  Lines       37506    8757   -28749     
  Branches      787     135     -652     
=========================================
- Hits        31681    7034   -24647     
+ Misses       5615    1674    -3941     
+ Partials      210      49     -161     
Flag Coverage 螖
integrationtests 78.6% <酶> (+10.7%) 猬嗭笍
unittests 86.4% <酶> (+4.8%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) 猬囷笍
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) 猬囷笍
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) 猬囷笍
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) 猬囷笍
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) 猬囷笍
...k/src/simcore_sdk/node_ports_v2/port_validation.py 47.9% <0.0%> (-48.0%) 猬囷笍
...ervice_director_v2/api/routes/dynamic_scheduler.py 50.0% <0.0%> (-47.1%) 猬囷笍
...simcore_service_director_v2/api/routes/clusters.py 57.6% <0.0%> (-41.1%) 猬囷笍
...e_service_director_v2/modules/projects_networks.py 38.2% <0.0%> (-37.1%) 猬囷笍
...ore_service_director_v2/utils/dask_client_utils.py 46.0% <0.0%> (-34.8%) 猬囷笍
... and 774 more

@GitHK GitHK changed the title test is still flaky 馃悰 test is still flaky Dec 16, 2022
@pcrespov
Copy link
Member

@GitHK keep an eye on this one ... it might be a hidden bug

@GitHK
Copy link
Contributor Author

GitHK commented Dec 16, 2022

@GitHK keep an eye on this one ... it might be a hidden bug

Yes, I also thought about this. I'll do another review of it next sprint.

@GitHK GitHK added this to the Zefram Cochrane milestone Dec 16, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not forget, add the case to the epic, it makes it easier to create the list of changes for the reviews:
image

@GitHK GitHK enabled auto-merge (squash) December 16, 2022 09:46
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@GitHK GitHK changed the title 馃悰 test is still flaky 馃悰 test_port_key_sequential_event_generation is still flaky Dec 16, 2022
@GitHK
Copy link
Contributor Author

GitHK commented Feb 6, 2023

closing, out of date

@GitHK GitHK closed this Feb 6, 2023
auto-merge was automatically disabled February 6, 2023 15:57

Pull request was closed

@GitHK GitHK deleted the mark-flaky-tests-dy-sidecar branch February 6, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants