-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fixes flaky tests with dynamic-sidecar #3681
🐛 fixes flaky tests with dynamic-sidecar #3681
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3681 +/- ##
=========================================
- Coverage 84.4% 69.4% -15.0%
=========================================
Files 883 395 -488
Lines 37506 20292 -17214
Branches 787 135 -652
=========================================
- Hits 31664 14088 -17576
- Misses 5632 6155 +523
+ Partials 210 49 -161
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/outputs/_watcher.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have a look at this spying thing together
@sanderegg @pcrespov caught a few more flaky tests and fixed here for the dynamic-sidecar |
@GitHK if so, please list them as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's have a look at this spying thing together
there was no such entry, I've detected them today. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Fixes flaky tests in the dynamic-sidecar:
services/dynamic-sidecar/tests/unit/test_api_containers.py::test_outputs_watcher_disabling
tests/unit/test_modules_outputs_event_filter.py::test_minimum_amount_of_get_directory_total_size_calls
tests/unit/test_modules_outputs_watcher.py::test_port_key_sequential_event_generation
Related issue/s
How to test
Checklist