Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 agent rclone error is also included when logged #3677

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 14, 2022

What do these changes do?

Helps with debugging since the application is running at warning log level. Currently on master I've just realised there is an issue but the log level is too high (which is correct) and the error is not logged. Including it where it makes sense.

Related issue/s

How to test

Checklist

@GitHK GitHK self-assigned this Dec 14, 2022
@GitHK GitHK added this to the Zefram Cochrane milestone Dec 14, 2022
@GitHK GitHK marked this pull request as ready for review December 14, 2022 09:45
@GitHK GitHK enabled auto-merge (squash) December 14, 2022 09:46
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #3677 (1c59e2d) into master (e5d335a) will decrease coverage by 14.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3677      +/-   ##
=========================================
- Coverage    82.4%   68.2%   -14.3%     
=========================================
  Files         883     373     -510     
  Lines       37382   18704   -18678     
  Branches      785     135     -650     
=========================================
- Hits        30818   12763   -18055     
+ Misses       6356    5892     -464     
+ Partials      208      49     -159     
Flag Coverage 螖
integrationtests 67.7% <酶> (+<0.1%) 猬嗭笍
unittests 95.3% <酶> (+14.3%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...mcore_service_agent/modules/volumes_cleanup/_s3.py 98.2% <酶> (酶)
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) 猬囷笍
...es/web/server/src/simcore_service_webserver/log.py 0.0% <0.0%> (-94.8%) 猬囷笍
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) 猬囷笍
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-76.0%) 猬囷笍
...rc/simcore_service_webserver/version_control_db.py 24.5% <0.0%> (-68.7%) 猬囷笍
...ce_webserver/studies_dispatcher/_studies_access.py 22.2% <0.0%> (-64.9%) 猬囷笍
...src/simcore_service_webserver/activity/handlers.py 29.3% <0.0%> (-63.8%) 猬囷笍
...src/simcore_service_webserver/clusters/handlers.py 34.0% <0.0%> (-63.0%) 猬囷笍
...ver/src/simcore_service_webserver/catalog_units.py 24.0% <0.0%> (-61.2%) 猬囷笍
... and 647 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants