Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敤 Maintenance: fixes requirement listings and scripts #3184

Merged
merged 8 commits into from
Jul 13, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 12, 2022

What do these changes do?

Fixes some issues related to the requirements listings:

  • fixes requirements dependencies in storage and web-server
  • fixes Makefile recipe in e2e/requirements

Related issue/s

@pcrespov pcrespov requested a review from sanderegg as a code owner July 12, 2022 13:00
@pcrespov pcrespov self-assigned this Jul 12, 2022
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jul 12, 2022
@pcrespov pcrespov added this to the Meteora milestone Jul 12, 2022
@pcrespov pcrespov requested review from colinRawlings, mrnicegyu11, Surfict and odeimaiz and removed request for Surfict, mrnicegyu11 and odeimaiz July 12, 2022 13:01
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3184 (049be8c) into master (e4850d2) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3184   +/-   ##
======================================
  Coverage    81.8%   81.8%           
======================================
  Files         724     724           
  Lines       31148   31148           
  Branches     4024    4024           
======================================
+ Hits        25503   25504    +1     
- Misses       4824    4825    +1     
+ Partials      821     819    -2     
Flag Coverage 螖
integrationtests 66.4% <酶> (酶)
unittests 78.3% <酶> (-0.1%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ore_service_director_v2/utils/dask_client_utils.py 78.2% <0.0%> (-5.3%) 猬囷笍
...mcore_service_webserver/garbage_collector_utils.py 82.0% <0.0%> (-2.6%) 猬囷笍
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 80.2% <0.0%> (-1.4%) 猬囷笍
...simcore_service_director_v2/modules/node_rights.py 97.2% <0.0%> (-1.0%) 猬囷笍
...simcore_service_director_v2/modules/dask_client.py 92.8% <0.0%> (+0.5%) 猬嗭笍
...e_service_director_v2/modules/dask_clients_pool.py 94.2% <0.0%> (+1.4%) 猬嗭笍
...rector_v2/modules/comp_scheduler/base_scheduler.py 88.6% <0.0%> (+1.8%) 猬嗭笍
...ore_service_director_v2/utils/client_decorators.py 76.6% <0.0%> (+3.3%) 猬嗭笍
...ector_v2/modules/comp_scheduler/background_task.py 91.6% <0.0%> (+8.3%) 猬嗭笍
...rvice-library/src/servicelib/common_aiopg_utils.py 97.0% <0.0%> (+8.8%) 猬嗭笍

@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 2e85e01 into ITISFoundation:master Jul 13, 2022
@pcrespov pcrespov deleted the maintenance/week-18 branch July 13, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants