Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ uvicorn upgrade #2748

Merged
merged 2 commits into from
Jan 17, 2022
Merged

⬆️ uvicorn upgrade #2748

merged 2 commits into from
Jan 17, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 17, 2022

What do these changes do?

Dependency upgrades uvicorn == 0.17.0. Also removes constraints.

Related issue/s

How to test

Checklist

@GitHK GitHK requested a review from pcrespov as a code owner January 17, 2022 11:18
@GitHK GitHK added this to the Rudolph milestone Jan 17, 2022
@GitHK GitHK added the t:maintenance Some planned maintenance work label Jan 17, 2022
@GitHK GitHK self-assigned this Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #2748 (5a2b2b3) into master (093554c) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2748     +/-   ##
========================================
- Coverage    79.1%   79.1%   -0.1%     
========================================
  Files         677     677             
  Lines       27018   27018             
  Branches     2618    2618             
========================================
- Hits        21393   21378     -15     
- Misses       4890    4901     +11     
- Partials      735     739      +4     
Flag Coverage Δ
integrationtests 65.6% <ø> (-0.1%) ⬇️
unittests 74.9% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...rvice_datcore_adapter/utils/requests_decorators.py 71.0% <0.0%> (-7.9%) ⬇️
...simcore_service_webserver/projects/project_lock.py 94.7% <0.0%> (-5.3%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 67.5% <0.0%> (-3.2%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 92.9% <0.0%> (-2.2%) ⬇️

@GitHK GitHK requested a review from sanderegg January 17, 2022 12:21
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GitHK GitHK merged commit 67a91d5 into ITISFoundation:master Jan 17, 2022
@GitHK GitHK deleted the upgrade-uvicorn branch January 17, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants