Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ upgrades dependencies #2733

Merged
merged 17 commits into from
Jan 17, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 11, 2022

What do these changes do?

This batch of upgrades focused on brining FastAPI to the latest version. The following packages were upgraded:

  • httpx==0.21.3
  • respx==0.19.1 (released constraint on respx~=0.17.1)
  • fastapi==0.71.0 only minor adjustments to tests due to how starlette's TestClient works. Note that FastAPI has added and removed new packages since the previous release.

Other libs:

  • black==21.12b0
  • aiofiles==0.8.0

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #2733 (01f98a8) into master (dfc0794) will increase coverage by 0.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2733     +/-   ##
========================================
+ Coverage    78.3%   79.1%   +0.7%     
========================================
  Files         677     677             
  Lines       27011   27012      +1     
  Branches     2617    2617             
========================================
+ Hits        21164   21379    +215     
+ Misses       5135    4900    -235     
- Partials      712     733     +21     
Flag Coverage Δ
integrationtests 65.6% <ø> (+<0.1%) ⬆️
unittests 74.9% <100.0%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/simcore_service_dynamic_sidecar/core/utils.py 80.6% <100.0%> (+0.2%) ⬆️
...c/simcore_service_catalog/services/remote_debug.py 50.0% <0.0%> (-12.5%) ⬇️
...ector_v2/modules/comp_scheduler/background_task.py 78.4% <0.0%> (-7.9%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 81.5% <0.0%> (-0.7%) ⬇️
.../director/src/simcore_service_director/producer.py 61.4% <0.0%> (+0.4%) ⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.7% <0.0%> (+1.0%) ⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 95.0% <0.0%> (+1.4%) ⬆️
..._director_v2/modules/dynamic_sidecar/client_api.py 70.6% <0.0%> (+1.8%) ⬆️
...log/src/simcore_service_catalog/api/routes/dags.py 65.1% <0.0%> (+6.9%) ⬆️
... and 14 more

@GitHK GitHK added the t:maintenance Some planned maintenance work label Jan 14, 2022
@GitHK GitHK added this to the Rudolph milestone Jan 14, 2022
@GitHK GitHK requested review from pcrespov and sanderegg and removed request for pcrespov January 14, 2022 13:49
@GitHK GitHK marked this pull request as ready for review January 14, 2022 13:50
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! We had this constraint for a while! Added some questions

I also suggest to keep in sync the versions of black in the .pre-commit-config.yaml. It would be very annoying if vscode tools (using the version in _tools.txt) behaves in one way
and when you commit everything gets re-formatted in another due to the commit hooks :-)

So, all in all: we should not forget to keep the pre-commit tools versions in sync with those used locally (they are installed in different venv)

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@GitHK GitHK merged commit 1187034 into ITISFoundation:master Jan 17, 2022
@GitHK GitHK deleted the maintenance-lib-upgrades branch January 17, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants