Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Study screenshot as thumbnail #2448

Draft
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 28, 2021

What do these changes do?

screenshot

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Jul 28, 2021
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Jul 28, 2021
@odeimaiz odeimaiz added this to the Wombat milestone Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #2448 (0a60890) into master (6c63bef) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2448     +/-   ##
========================================
- Coverage    78.2%   78.2%   -0.1%     
========================================
  Files         673     673             
  Lines       27602   27602             
  Branches     3218    3218             
========================================
- Hits        21596   21586     -10     
- Misses       5222    5282     +60     
+ Partials      784     734     -50     
Flag Coverage Δ
integrationtests 62.0% <ø> (-3.7%) ⬇️
unittests 74.7% <ø> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 38.6% <0.0%> (-56.3%) ⬇️
...ules/dynamic_sidecar/docker_service_specs/proxy.py 53.8% <0.0%> (-46.2%) ⬇️
.../modules/dynamic_sidecar/scheduler/events_utils.py 55.5% <0.0%> (-44.5%) ⬇️
...v2/modules/dynamic_sidecar/docker_compose_specs.py 54.6% <0.0%> (-42.2%) ⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py 55.4% <0.0%> (-26.8%) ⬇️
...tor_v2/modules/dynamic_sidecar/volumes_resolver.py 64.1% <0.0%> (-20.6%) ⬇️
...s/dynamic_sidecar/docker_service_specs/settings.py 33.1% <0.0%> (-15.3%) ⬇️
...vice_director_v2/modules/dynamic_sidecar/errors.py 82.6% <0.0%> (-13.1%) ⬇️
...es/dynamic_sidecar/docker_service_specs/sidecar.py 68.2% <0.0%> (-7.4%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 68.2% <0.0%> (-1.0%) ⬇️
... and 34 more

@odeimaiz odeimaiz modified the milestones: Wombat, Chevrotain Aug 9, 2021
@pcrespov pcrespov modified the milestones: Chevrotain, Rudolph Jan 15, 2022
@pcrespov pcrespov removed this from the Rudolph milestone Feb 4, 2022
@pcrespov pcrespov removed this from the R.Schumann milestone Mar 14, 2022
@pcrespov pcrespov added this to the E.Shackleton milestone Mar 24, 2022
@pcrespov pcrespov modified the milestones: Katherine Switzer, Athena Nov 23, 2022
@pcrespov pcrespov modified the milestones: Athena, Zefram Cochrane Dec 14, 2022
@pcrespov pcrespov modified the milestones: Jelly Beans, Pastel de Nata May 10, 2023
@pcrespov pcrespov modified the milestones: Pastel de Nata, Watermelon Jun 23, 2023
@pcrespov pcrespov modified the milestones: Watermelon, Sundae Jul 19, 2023
@pcrespov pcrespov modified the milestones: Sundae, Schoggilebe Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants