Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

♻️Maintenance: fixes and refactoring #48

Merged
merged 12 commits into from
Mar 9, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 9, 2023

What do these changes do?

  • adds scripts/docker-compose-config.bash to allow for running config using both docker-compose (V1) or docker compose (V2). If V2 is present will use V2.
  • adds --resolver=backtracking to pip-compile call
  • upgrade cloudpickle to latest version (same as in osparc-simcore:master)
  • where applicable removes tests agains staging/production images of dask-sidecar. next step would be moving the repository into osparc-simcore

Related issue/s

fixes ITISFoundation/osparc-issues#885
fixes ITISFoundation/osparc-issues#675

How to test

Checklist

@sanderegg sanderegg added the dependencies Pull requests that update a dependency file label Mar 9, 2023
@sanderegg sanderegg added this to the Mithril milestone Mar 9, 2023
@sanderegg sanderegg self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #48 (c466228) into main (b311756) will increase coverage by 41.9%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main     #48      +/-   ##
========================================
+ Coverage   42.4%   84.3%   +41.9%     
========================================
  Files          8       8              
  Lines        377     377              
========================================
+ Hits         160     318     +158     
+ Misses       217      59     -158     
Flag Coverage Δ
integrationtests 79.5% <ø> (?)
unittests 42.4% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y-server/src/osparc_gateway_server/remote_debug.py 20.0% <0.0%> (+20.0%) ⬆️
...-server/src/osparc_gateway_server/backend/utils.py 90.4% <0.0%> (+21.0%) ⬆️
...server/src/osparc_gateway_server/backend/osparc.py 82.7% <0.0%> (+82.7%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanderegg sanderegg marked this pull request as ready for review March 9, 2023 12:27
@sanderegg sanderegg merged commit a83d990 into ITISFoundation:main Mar 9, 2023
@sanderegg sanderegg deleted the maintenance/more_fixes branch March 9, 2023 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppTeam Std Simulations on S4L/AWS M1-12 Maintenance and DevOps
3 participants